Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): ダイレクト投稿をユーザーごとのチャートから除外 #14350

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

非公開のアクティビティを公開するのはよくない気がするため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.91%. Comparing base (0aaf74e) to head (79c7f95).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14350      +/-   ##
===========================================
+ Coverage    38.88%   39.91%   +1.02%     
===========================================
  Files         1545     1545              
  Lines       190490   190490              
  Branches      2409     2699     +290     
===========================================
+ Hits         74072    76027    +1955     
+ Misses      115857   113902    -1955     
  Partials       561      561              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12
Copy link
Member

除外してほしいかは人によるきはするけどオプションを付けるほどのことでもなさそうだから除外のほうがいいのかな...

@syuilo syuilo merged commit ab7bbd4 into misskey-dev:develop Aug 11, 2024
14 of 17 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 11, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-notechart-specified branch August 11, 2024 07:29
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
* fix(chart): ダイレクト投稿をユーザーごとのチャートから除外 (MisskeyIO#679)

(cherry picked from commit 3db41c2)

* Update Changelog

---------

Co-authored-by: Yuuki <[email protected]>
Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants