feat: 個別のお知らせにリンクで飛べるように

[kakkokari-gtyih]

What

書いてあるとおり

MisskeyIO#639
およびioのAnnouncementEntityService周りの変更を取り込み

Why

特定のお知らせを引用するときなどに個別リンクが有るとよい

ioからの変更点

• お知らせを個別に取得するendpointをannouncements/showに移動
• 一覧ページではタイトルもリンクとして機能するように
• 画面上部のお知らせバーは既定でお知らせ個別ページに飛ばすように

Additional info (optional)

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

[codecov]

Codecov Report

Attention: Patch coverage is 71.26437% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 66.43%. Comparing base (e0b4799) to head (397409f).

Files	Patch %	Lines
...end/src/core/entities/AnnouncementEntityService.ts	73.23%	19 Missing ⚠️
packages/backend/src/core/AnnouncementService.ts	27.27%	16 Missing ⚠️
...end/src/server/api/endpoints/announcements/show.ts	75.92%	13 Missing ⚠️
.../backend/src/server/api/endpoints/announcements.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #13885    +/-   ##
=========================================
  Coverage    66.42%   66.43%            
=========================================
  Files          990      992     +2     
  Lines       116887   117027   +140     
  Branches      4503     4508     +5     
=========================================
+ Hits         77647    77742    +95     
- Misses       39209    39254    +45     
  Partials        31       31            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

このPRによるapi.jsonの差分

差分はこちら

--- base
+++ head
@@ -15188,6 +15188,166 @@
         }
       }
     },
+    "/announcements/show": {
+      "post": {
+        "operationId": "announcements___show",
+        "summary": "announcements/show",
+        "description": "No description provided.\n\n**Credential required**: *No*",
+        "externalDocs": {
+          "description": "Source code",
+          "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/announcements/show.ts"
+        },
+        "tags": [
+          "meta"
+        ],
+        "requestBody": {
+          "required": true,
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {
+                  "announcementId": {
+                    "type": "string",
+                    "format": "misskey:id"
+                  }
+                },
+                "required": [
+                  "announcementId"
+                ]
+              }
+            }
+          }
+        },
+        "responses": {
+          "200": {
+            "description": "OK (with results)",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "type": "object",
+                  "$ref": "#/components/schemas/Announcement"
+                }
+              }
+            }
+          },
+          "400": {
+            "description": "Client error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "NO_SUCH_ANNOUNCEMENT": {
+                    "value": {
+                      "error": {
+                        "message": "No such announcement.",
+                        "code": "NO_SUCH_ANNOUNCEMENT",
+                        "id": "b57b5e1d-4f49-404a-9edb-46b00268f121"
+                      }
+                    }
+                  },
+                  "INVALID_PARAM": {
+                    "value": {
+                      "error": {
+                        "message": "Invalid param.",
+                        "code": "INVALID_PARAM",
+                        "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "401": {
+            "description": "Authentication error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "CREDENTIAL_REQUIRED": {
+                    "value": {
+                      "error": {
+                        "message": "Credential required.",
+                        "code": "CREDENTIAL_REQUIRED",
+                        "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "403": {
+            "description": "Forbidden error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "AUTHENTICATION_FAILED": {
+                    "value": {
+                      "error": {
+                        "message": "Authentication failed. Please ensure your token is correct.",
+                        "code": "AUTHENTICATION_FAILED",
+                        "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "418": {
+            "description": "I'm Ai",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "I_AM_AI": {
+                    "value": {
+                      "error": {
+                        "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
+                        "code": "I_AM_AI",
+                        "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "500": {
+            "description": "Internal server error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "INTERNAL_ERROR": {
+                    "value": {
+                      "error": {
+                        "message": "Internal error occurred. Please contact us if the error persists.",
+                        "code": "INTERNAL_ERROR",
+                        "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    },
     "/antennas/create": {
       "post": {
         "operationId": "antennas___create",

Get diff files from Workflow Page

[kakkokari-gtyih]

お知らせを個別で取れるエンドポイントはannouncements/showにしたほうが良いかもしれない

[syuilo]

お知らせを個別で取れるエンドポイントはannouncements/showにしたほうが良いかもしれない

yosasou

[syuilo]

一覧ページではお知らせpanel全体を押せるように

お知らせ本文にリンクが含まれる可能性がありそう

[kakkokari-gtyih]

一覧ページではお知らせpanel全体を押せるように

お知らせ本文にリンクが含まれる可能性がありそう

下のリンクにクリックイベントは貫通しないはずなので問題ないと思われる

[syuilo]

とはいえHTMLの構造上二重リンクになりそう

[syuilo]

あとUX的に微妙かも

[kakkokari-gtyih]

あとUX的に微妙かも

どうするのがベターかしら

[kakkokari-gtyih]

タイトルだけ押せるようにするか

[kakkokari-gtyih]

タイトルだけ押せるようにするか

そうした

[syuilo]

/preview

[syuilo]

👍🏻