test(#10336): add components/Mk[A-B].* stories
#10475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #10475 +/- ##
===========================================
- Coverage 75.13% 75.10% -0.03%
===========================================
Files 887 886 -1
Lines 87219 87120 -99
Branches 5906 5904 -2
===========================================
- Hits 65533 65434 -99
Misses 21686 21686
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This reverts commit e649b1b.
acid-chicken
commented
Apr 10, 2023
There was a problem hiding this comment.
ぶっちゃけここだけ見てもらえればいいはずなのでよろしくお願いします
|
マージしてよいか |
|
🙏🙏 |
tamaina
added a commit
to tamaina/misskey
that referenced
this pull request
Apr 13, 2023
…isskey-dev#10475)" This reverts commit 9bb6c53.
acid-chicken
added a commit
that referenced
this pull request
Apr 13, 2023
This reverts commit 7d11cf8.
tamaina
added a commit
to tamaina/misskey
that referenced
this pull request
Apr 13, 2023
…tories (misskey-dev#10475)"" This reverts commit 1fd2661.
tamaina
added a commit
that referenced
this pull request
Apr 13, 2023
* perf: remove isChromatic on real build * revert: Revert #10475 in MkTime This reverts commit 7d11cf8. * @rollup/plugin-replace as dependencies * fix pnpm-lock,yaml --------- Co-authored-by: tamaina <[email protected]>
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
…dev#10475) * chore(misskey-dev#10336): register snippets * test(misskey-dev#10336): add `components/Mk[A-B].*` stories * build: desynced lockfile * ci(misskey-dev#10336): preload assets * ci(misskey-dev#10336): use pull_request * build: update lockfile * fix: reactivity transform * chore: track upstream changes * refactor: avoid temporary previous tapping declarations * revert: avoid temporary previous tapping declarations This reverts commit e649b1b. * test: flaky snapshots * style: import
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
…#10613) * perf: remove isChromatic on real build * revert: Revert misskey-dev#10475 in MkTime This reverts commit 7d11cf8. * @rollup/plugin-replace as dependencies * fix pnpm-lock,yaml --------- Co-authored-by: tamaina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
以下のコンポーネントに対する stories を定義
components/MkAbuseReportcomponents/MkAbuseReportWindowcomponents/MkAchievementscomponents/MkAnalogClockcomponents/MkAutocompletecomponents/MkAvatarscomponents/MkButtonWhy
#10336
Additional info (optional)
ついでの細かい変更（スニペット追加など）あり
Checklist