Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelogの検査ワークフローが不整合を検出している #14234

Closed
KisaragiEffective opened this issue Jul 17, 2024 · 14 comments
Closed
Labels
🛠️Dev Development of Misskey itself

Comments

@KisaragiEffective
Copy link
Collaborator

仕様?

https://github.com/misskey-dev/misskey/actions/workflows/changelog-check.yml?query=branch%3Adevelop

@KisaragiEffective KisaragiEffective added the 🛠️Dev Development of Misskey itself label Jul 17, 2024
@anatawa12
Copy link
Member

前回のリリース時点でmasterにUnreleasedのエントリが入っているのが原因っぽそう

@KisaragiEffective
Copy link
Collaborator Author

じゃあdevelop側に# Unreleasedを足せば良いのかな…… 🤔

@anatawa12
Copy link
Member

#13917 のheadが cc1ee01 であるべきところが 2b8056a になっちゃってる

@anatawa12
Copy link
Member

じゃあdevelop側に# Unreleasedを足せば良いのかな…… 🤔

それはあまり良くないと思う
一時的にワークフローにパッチを当てれば一応良さそうかなぁ

@anatawa12
Copy link
Member

とりあえず仕様ではあるけど無視するか対策するかは議論で決めるべきだと思います

@KisaragiEffective KisaragiEffective added the 💬Discussion Being discussed or needs discussion label Jul 17, 2024
@tamaina
Copy link
Contributor

tamaina commented Jul 17, 2024

じゃあdevelop側に# Unreleasedを足せば良いのかな…… 🤔

これをやられてしまうとRelease actionsの挙動に問題が出そう

(だし正式リリース後にChangelogにテンプレートを自動で付加するのでUnreleasedは不要)

@tamaina
Copy link
Contributor

tamaina commented Jul 17, 2024

Release actionsのお節介機能(Unreleasedをターゲット作成時にバージョンで書き換えたりリリース後にテンプレートを付加したり)とchangelog-checkerの相性というか考え方が全くあってなさそう

@anatawa12
Copy link
Member

Unreleasedの追加がDevelop側だけなのであれば、問題なく動くはずです

@tamaina

This comment was marked as duplicate.

@tamaina

This comment was marked as off-topic.

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jul 17, 2024

masterからUnreleased消したほうがいいのかしら
(と、ここまで書いた段階でbranch rulesでアクセスできないことに気づく)

@anatawa12
Copy link
Member

消したほうがいいのはそう。Pullreqによるバイパスをしゅいろさんにつけてもらう必要はあるかも

@anatawa12
Copy link
Member

https://github.com/misskey-dev/misskey/actions/runs/9986019295/job/27597816498?pr=14233

ちゃんと通るようになった

@KisaragiEffective KisaragiEffective removed the 💬Discussion Being discussed or needs discussion label Jul 18, 2024
@KisaragiEffective
Copy link
Collaborator Author

多分解決したので閉じる

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️Dev Development of Misskey itself
Projects
None yet
Development

No branches or pull requests

4 participants