Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFMjs will fail to parse users including dots in their ID #144

Open
HotoRas opened this issue Jun 13, 2024 · 3 comments · May be fixed by #150
Open

MFMjs will fail to parse users including dots in their ID #144

HotoRas opened this issue Jun 13, 2024 · 3 comments · May be fixed by #150

Comments

@HotoRas
Copy link

HotoRas commented Jun 13, 2024

💡 Summary

Lately Bluesky has begun one-way federation into ActivityPub. However, unlike Misskey, Bluesky allows dots (.) in their user IDs. Since MFMjs don't expect dots in the username part of the user, mentioning those users will end up broken result.

🥰 Expected Behavior

The whole User ID (e.g. @[email protected]) will be parsed as user.

🤬 Actual Behavior

ID before dots (@example in the case above) will be parsed as user and the rest will remain as string.

📝 Steps to Reproduce

  1. Open any of the Misskey server (or MFM-supported site- no matters) and open note post.
  2. Type any mentions including dots in their username part.
  3. Open preview. (If you want you can just post it)

💻 Frontend Environment

  • Model and OS of the device(s): Samsung Galaxy Note 20 Ultra (Korean), Android 12
  • Browser: Chrome Beta 127.0.6521.0 (Official Build) dev (64-bit)
  • Misskey:
    • Server URL: Nekoplanet (Korean Server)
    • Version: 2024.3.1+neko-rc
@zyoshoka
Copy link
Contributor

Related to #143

@kakkokari-gtyih
Copy link

Lately Bluesky has begun one-way federation into ActivityPub

(Off-topic) Really? Haven't heard of that (unless it's third-party bridge)

@HotoRas
Copy link
Author

HotoRas commented Jul 16, 2024

(Off-topic) Really? Haven't heard of that (unless it's third-party bridge)

Yup it's bridge- but same happens here

easrng added a commit to easrng/mfm.js that referenced this issue Oct 29, 2024
easrng added a commit to easrng/mfm.js that referenced this issue Oct 29, 2024
easrng added a commit to easrng/mfm.js that referenced this issue Oct 29, 2024
@Sayamame-beans Sayamame-beans linked a pull request Nov 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants