fix(ui): add login popin connexion #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenfares
reviewed
Apr 21, 2022
Comment on lines
47
to
52
| history: PropTypes.shape({ | ||
| location: PropTypes.shape({ | ||
| search: PropTypes.string, | ||
| }).isRequired, | ||
| push: PropTypes.func.isRequired, | ||
| }).isRequired, |
sbenfares
requested changes
Apr 21, 2022
ui/src/pages/login/LoginModal.js
Outdated
Comment on lines
15
to
24
| const login = async (values, { setStatus }) => { | ||
| try { | ||
| const { access_token } = await _post("/api/login", values); | ||
| setAuth(access_token); | ||
| history.push("/"); | ||
| } catch (e) { | ||
| console.error(e); | ||
| setStatus({ error: e.prettyMessage }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Ce code est dupliqué dans 2 fichiers du coup.
Jte propose de le mettre dans une fonction unique dans un composant dans common/auth/login.js par exemple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.