fix: siret_valid = true while siret is not valid #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pabloHry
approved these changes
Jun 1, 2022
| @@ -92,6 +92,11 @@ const updateDossierApprenant = async (existingItemId, toUpdate) => { | |||
| ); | |||
| const existingItem = await DossierApprenantModel.findById(existingItemId); | |||
|
|
|||
| // handle siret update & siret_etablissement_valid update value | |||
There was a problem hiding this comment.
On accepte explicitement l'update de SIRET donc (plutôt logique vu que le champ n'est pas obligatoire et pas dans la clé d'unicité)
|
|
||
| // Search for invalid siret while valid field true | ||
| if (!validateSiret(currentSiretValid)) { | ||
| logger.info(currentSiretValid); |
There was a problem hiding this comment.
Pas forcément utile de log le SIRET ?
There was a problem hiding this comment.
ah oui c t un reliquat de debug je pense 🤣
| logger.info("Run DossierApprenant - Fix SIRET invalid Job"); | ||
|
|
||
| // Retrieve all distinct siret valid | ||
| const distinctSiretValidFromDossierApprenants = await DossierApprenantModel.distinct("siret_etablissement", { |
There was a problem hiding this comment.
On passe à côté des éventuels SIRET qui étaient invalides (car non fournis) mais qui le sont depuis suite à un update
There was a problem hiding this comment.
Oui bien vu je vais modif le script pour gérer ces cas
sbenfares
force-pushed
the
feature/fix-update-dossiersApprenants-siret-valid-update
branch
from
00518a1 to
544c494
Compare
stephane-ruhlmann
approved these changes
Jun 1, 2022
sbenfares
deleted the
feature/fix-update-dossiersApprenants-siret-valid-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.