Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing better error messages in uglify #1132

Closed
avdg opened this issue Jun 13, 2016 · 6 comments
Closed

Enforcing better error messages in uglify #1132

avdg opened this issue Jun 13, 2016 · 6 comments

Comments

@avdg
Copy link
Contributor

avdg commented Jun 13, 2016

As proposed in tc39/test262#196 (notified from tc39/test262#671 (comment)), test262 coverage may include well formatted error messages.

I still have to take a look into this one because this could involve in very many additional errors the test suite and would require mocha tests to be updated as well.

The upside is that there is a certain probability that the python test262 tester might not get this update. But since this tool is declared officially deprecated in tc39/test262#647, this still might have an effect later on.

So to reduce impact, it might be better to look at the required changes and take an inventory of them as soon as possible.

@avdg
Copy link
Contributor Author

avdg commented Jun 13, 2016

There is no need to fix this problem on master, though consistent errors might be welcome.

@avdg
Copy link
Contributor Author

avdg commented Jun 13, 2016

I might have to switch to https://github.com/bterlson/test262-harness over time as alternative.

@avdg
Copy link
Contributor Author

avdg commented Jul 2, 2016

Master branch should be fine for now. Now it's just a wait and see game while master merges with harmony and then having to fix harmony as well.

@kzc
Copy link
Contributor

kzc commented Jul 2, 2016

@avdg In your test262 testing do you enable mangle?

@avdg
Copy link
Contributor Author

avdg commented Jul 2, 2016

@avdg
Copy link
Contributor Author

avdg commented Jul 3, 2016

Seems harmony is fine after merge. Closing.

@avdg avdg closed this as completed Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants