Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service (bot) accounts #3343

Closed
patrys opened this issue Nov 27, 2018 · 3 comments
Closed

Service (bot) accounts #3343

patrys opened this issue Nov 27, 2018 · 3 comments
Labels
graphql Issues related to the GraphQL API integrations
Milestone

Comments

@patrys
Copy link
Member

patrys commented Nov 27, 2018

Saleor now has a robust API that powers our new dashboard. That API would also make a great integration point (even if currently missing some useful mutations) for third-party services like external stock management or price synchronization. We are however missing a robust method to invoke those APIs in a S2S configuration.

Service accounts

I propose that we add a new flag to the User model indicating whether the account is meant to be used by a human or a machine (is_service? is_bot?).

  • A new permission would allow admins to create, edit and remove (deactivate?) service accounts.
  • Service accounts would use permissions in the same fashion as regular accounts do.
  • Service accounts would not be allowed to use a password to authenticate.
  • Service accounts would be able to authenticate using OAuth2 service (server to server) flow
  • The dashboard should include an icon indicating that any given account is a service account when displaying its name ("created by 🤖SalesForce Robot", "last edited by 🤖Slack Integration" etc.). The icon itself is TBD.

The proposed workflow for integrations would be to (instead of building them into Saleor) deploy them as AWS Lambda functions or small Node containers that each use a dedicated service account with a tailored set of permissions to talk to the GraphQL API.

@patrys patrys added discussion integrations graphql Issues related to the GraphQL API labels Nov 27, 2018
@NyanKiyoshi
Copy link
Member

We will soon only be missing #2084 in the whole awesomeness 😉

@maarcingebala maarcingebala added this to the GraphQL milestone Dec 12, 2018
@maarcingebala maarcingebala removed this from the GraphQL milestone Jan 31, 2019
@maarcingebala maarcingebala added this to the Backlog milestone Apr 8, 2019
@Satloff
Copy link
Contributor

Satloff commented Jun 10, 2019

Any progress on this or #2084?

@maarcingebala
Copy link
Member

We now have support for service accounts in the API (#4689), UI for Dashboard 2.0 is under construction (saleor/saleor-dashboard#188)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API integrations
Projects
None yet
Development

No branches or pull requests

4 participants