Skip to content

Commit

Permalink
Address code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@miroiu
miroiu committed Jun 25, 2024
1 parent 126524b commit 57984f0
Show file tree
Hide file tree
Showing 2 changed files with 189 additions and 176 deletions.
341 changes: 178 additions & 163 deletions Examples/Nodify.Shapes/App.xaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,182 +45,197 @@

<!--ICONS-->

<Viewbox x:Key="MinusIcon"
Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 12h14" />
</Grid>
</Viewbox>
<DataTemplate x:Key="MinusIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 12h14" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="PlusIcon"
Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M12 5v14M5 12h14" />
</Grid>
</Viewbox>

<Viewbox x:Key="MaximizeIcon"
Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M4 8V6a2 2 0 0 1 2-2h2M4 16v2a2 2 0 0 0 2 2h2M16 4h2a2 2 0 0 1 2 2v2M16 20h2a2 2 0 0 0 2-2v-2" />
</Grid>
</Viewbox>
<DataTemplate x:Key="PlusIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M12 5v14M5 12h14" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="CursorIcon"
Stretch="Fill"
Margin="2">
<Path Stroke="White"
StrokeThickness="1"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M.256.255a.874.874 0 0 0-.18.974l4.753 17.114a.875.875 0 0 0 1.603-.012L10 10l8.334-3.57a.875.875 0 0 0 .01-1.601L1.23.075a.874.874 0 0 0-.974.18Z" />
</Viewbox>
<DataTemplate x:Key="MaximizeIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M4 8V6a2 2 0 0 1 2-2h2M4 16v2a2 2 0 0 0 2 2h2M16 4h2a2 2 0 0 1 2 2v2M16 20h2a2 2 0 0 0 2-2v-2" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="CircleIcon"
Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<DataTemplate x:Key="CursorIcon">
<Viewbox Stretch="Fill"
Margin="2">
<Path Stroke="White"
StrokeThickness="1"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M3 12a9 9 0 1 0 18 0 9 9 0 1 0-18 0" />
</Grid>
</Viewbox>
Data="M.256.255a.874.874 0 0 0-.18.974l4.753 17.114a.875.875 0 0 0 1.603-.012L10 10l8.334-3.57a.875.875 0 0 0 .01-1.601L1.23.075a.874.874 0 0 0-.974.18Z" />
</Viewbox>
</DataTemplate>

<Viewbox x:Key="SquareIcon" Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M3 5a2 2 0 0 1 2-2h14a2 2 0 0 1 2 2v14a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2z" />
</Grid>
</Viewbox>
<DataTemplate x:Key="CircleIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M3 12a9 9 0 1 0 18 0 9 9 0 1 0-18 0" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="TriangleIcon" Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M10.363 3.591 2.257 17.125a1.914 1.914 0 0 0 1.636 2.871h16.214a1.914 1.914 0 0 0 1.636-2.87L13.637 3.59a1.914 1.914 0 0 0-3.274 0z" />
</Grid>
</Viewbox>
<DataTemplate x:Key="SquareIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M3 5a2 2 0 0 1 2-2h14a2 2 0 0 1 2 2v14a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2z" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="ArrowBackIcon" Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="m9 14-4-4 4-4" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 10h11a4 4 0 1 1 0 8h-1" />
</Grid>
</Viewbox>
<DataTemplate x:Key="TriangleIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M10.363 3.591 2.257 17.125a1.914 1.914 0 0 0 1.636 2.871h16.214a1.914 1.914 0 0 0 1.636-2.87L13.637 3.59a1.914 1.914 0 0 0-3.274 0z" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="ArrowForwardIcon" Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="m15 14 4-4-4-4" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M19 10H8a4 4 0 1 0 0 8h1" />
</Grid>
</Viewbox>
<DataTemplate x:Key="ArrowBackIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="m9 14-4-4 4-4" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 10h11a4 4 0 1 1 0 8h-1" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="LockIcon"
Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 13a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v6a2 2 0 0 1-2 2H7a2 2 0 0 1-2-2v-6z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M11 16a1 1 0 1 0 2 0 1 1 0 0 0-2 0M8 11V7a4 4 0 1 1 8 0v4" />
</Grid>
</Viewbox>
<DataTemplate x:Key="ArrowForwardIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="m15 14 4-4-4-4" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M19 10H8a4 4 0 1 0 0 8h1" />
</Grid>
</Viewbox>
</DataTemplate>

<Viewbox x:Key="LockOpenIcon"
Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 13a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v6a2 2 0 0 1-2 2H7a2 2 0 0 1-2-2z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M11 16a1 1 0 1 0 2 0 1 1 0 1 0-2 0M8 11V6a4 4 0 0 1 8 0" />
</Grid>
</Viewbox>
<DataTemplate x:Key="LockIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 13a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v6a2 2 0 0 1-2 2H7a2 2 0 0 1-2-2v-6z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M11 16a1 1 0 1 0 2 0 1 1 0 0 0-2 0M8 11V7a4 4 0 1 1 8 0v4" />
</Grid>
</Viewbox>
</DataTemplate>

<DataTemplate x:Key="LockOpenIcon">
<Viewbox Stretch="Fill">
<Grid>
<Path StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M0 0h24v24H0z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M5 13a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v6a2 2 0 0 1-2 2H7a2 2 0 0 1-2-2z" />
<Path Stroke="White"
StrokeLineJoin="Round"
StrokeStartLineCap="Round"
StrokeEndLineCap="Round"
Data="M11 16a1 1 0 1 0 2 0 1 1 0 1 0-2 0M8 11V6a4 4 0 0 1 8 0" />
</Grid>
</Viewbox>
</DataTemplate>
</ResourceDictionary>
</Application.Resources>
</Application>
Loading

0 comments on commit 57984f0

Please sign in to comment.