Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Nominatim (UnifiedNlp) #13

Open
IzzySoft opened this issue Nov 8, 2022 · 5 comments
Open

Include Nominatim (UnifiedNlp) #13

IzzySoft opened this issue Nov 8, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@IzzySoft
Copy link

IzzySoft commented Nov 8, 2022

Would it be possible to also include the UnifiedNlp Nominatim backend if installed, so one could see if it properly resolves?

@gdt
Copy link

gdt commented Nov 8, 2022

I think that makes sense, and presumably it would look up the GNSS location, or the network location, or maybe both. It's new scope as currently only location provider backends are queried and the API has to be different, but I think it fits within the scope of the app.

@IzzySoft
Copy link
Author

IzzySoft commented Nov 8, 2022

Yupp. It would use the coordinates obtained from any of the location providers (the one with the best precision) and pass that to the Nominatim backend, then check (and show) the result.

@mirfatif mirfatif added the enhancement New feature or request label Nov 9, 2022
@IzzySoft
Copy link
Author

IzzySoft commented Nov 9, 2022

??? Looks like the text part of your comment was lost. Not being an Android dev I'm not sure what the code you've linked to is supposed to tell me, @mirfatif 😉

…apart from the fact that this is a commit from 2019, while the last release of the NominatimBackend was 2017. So is there a fixed version? I've reason to assume that the last release available at F-Droid (1.2.2) no longer works, at least not on Android 9+.

@mirfatif
Copy link
Owner

mirfatif commented Nov 9, 2022

For you is the "enhancement" label. Comment is for me or someone who is interested in implementing this feature in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants