Retrieve blackouts from the alerta Model code #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om db code. This standardizes the data, so it is the same regardless of the database being used. Added the NOTIFICATION_BLACKOUT config param, which changes the behavior for alerts that are being raised during the blackout period.
mirceaulinic
reviewed
Jun 9, 2023
There was a problem hiding this comment.
Not sure how I missed this PR. I think the changes make sense. I believe you've tested this against an Alerta instance with some regex blackouts @headphonejames?
|
I did test it with an instance. Thanks. |
mirceaulinic
added a commit
that referenced
this pull request
Jul 18, 2023
mirceaulinic
added a commit
that referenced
this pull request
Jul 18, 2023
Fix unit tests after the changes from #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve blackouts from the alerta model code instead of the db code. This standardizes the data, so it is the same regardless of the database being used (postgres or MongoDB).
Added the NOTIFICATION_BLACKOUT config param, which changes the behavior for alerts that are being raised during the blackout period.