Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewerjs 升级了，使用typescript会有问题 #173

Closed
baixiaosh opened this issue May 26, 2021 · 2 comments
Closed

viewerjs 升级了，使用typescript会有问题 #173

baixiaosh opened this issue May 26, 2021 · 2 comments

Comments

@baixiaosh
Copy link

baixiaosh commented May 26, 2021 •
edited
Loading

报错提示：
Property 'flipHorizontal' of type 'boolean | 0 | Function | "small" | "medium" | 2 | 1 | 4 | 3 | "large" | ToolbarButtonOptions | undefined' is not assignable to string index type 'ToolbarOption'.
@mirari
Copy link
Owner

mirari commented May 26, 2021

看上去是viewerjs的ts声明里没有加上新属性，如果你知道如何修改，可以在本地验证后，直接到
https://github.com/fengyuanchen/viewerjs/blob/master/types/index.d.ts
修改并提交pr

@baixiaosh baixiaosh mentioned this issue May 26, 2021
Closed
@baixiaosh
Copy link
Author

已经有人提PR了 #473

@mirari mirari closed this as completed May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirari @baixiaosh