Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating indexes to Zenodo - Genís&Guillem #641

Merged
merged 45 commits into from
Nov 6, 2024

Conversation

genisplaja
Copy link
Collaborator

@genisplaja genisplaja commented Oct 30, 2024

Hello :) In this PR I am migrating some dataset indexes to Zenodo, and updating the data loader modules and tests with the remote mechanics.

Some pending things:

  • There are some core tests that do not run. I think it's related to the multitrack datasets. I think we should take a closer look... I am trying to see what's going on, will let you know if there is any update!
  • There is a problem in the multitrack Slakh with the dataset split.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05%. Comparing base (19600df) to head (c6161dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage   97.06%   97.05%   -0.02%     
==========================================
  Files          67       67              
  Lines        7537     7532       -5     
==========================================
- Hits         7316     7310       -6     
- Misses        221      222       +1     

@genisplaja genisplaja changed the title [WIP] Migrating indexes to Zenodo - Genís Migrating indexes to Zenodo - Genís Nov 2, 2024
@genisplaja genisplaja changed the title Migrating indexes to Zenodo - Genís Migrating indexes to Zenodo - Genís&Guillem Nov 3, 2024
@guillemcortes
Copy link
Collaborator

guillemcortes commented Nov 3, 2024

TODO list

@guillemcortes
Copy link
Collaborator

Hi @tanmayy24 ! This is ready to review, could you take a look? :)

@guillemcortes guillemcortes changed the title [WIP] Migrating indexes to Zenodo - Genís&Guillem Migrating indexes to Zenodo - Genís&Guillem Nov 4, 2024
mirdata/datasets/ikala.py Outdated Show resolved Hide resolved
mirdata/datasets/beatles.py Outdated Show resolved Hide resolved
mirdata/datasets/cante100.py Outdated Show resolved Hide resolved
mirdata/datasets/compmusic_carnatic_rhythm.py Outdated Show resolved Hide resolved
mirdata/datasets/compmusic_carnatic_rhythm.py Show resolved Hide resolved
mirdata/datasets/compmusic_hindustani_rhythm.py Outdated Show resolved Hide resolved
mirdata/datasets/compmusic_jingju_acappella.py Outdated Show resolved Hide resolved
mirdata/datasets/filosax.py Show resolved Hide resolved
mirdata/datasets/four_way_tabla.py Outdated Show resolved Hide resolved
@tanmayy24
Copy link
Collaborator

Thank you! Looks good to me!
Great that it happened before the release :))

@genisplaja genisplaja merged commit 62385ef into master Nov 6, 2024
10 checks passed
@genisplaja genisplaja deleted the genis/remote_indexes_genis branch November 6, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants