-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating indexes to Zenodo - Genís&Guillem #641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… genis/remote_indexes_genis
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
==========================================
- Coverage 97.06% 97.05% -0.02%
==========================================
Files 67 67
Lines 7537 7532 -5
==========================================
- Hits 7316 7310 -6
- Misses 221 222 +1 |
genisplaja
changed the title
[WIP] Migrating indexes to Zenodo - Genís
Migrating indexes to Zenodo - Genís
Nov 2, 2024
genisplaja
changed the title
Migrating indexes to Zenodo - Genís
Migrating indexes to Zenodo - Genís&Guillem
Nov 3, 2024
TODO list
|
… genis/remote_indexes_genis
… genis/remote_indexes_genis
Hi @tanmayy24 ! This is ready to review, could you take a look? :) |
guillemcortes
changed the title
[WIP] Migrating indexes to Zenodo - Genís&Guillem
Migrating indexes to Zenodo - Genís&Guillem
Nov 4, 2024
tanmayy24
reviewed
Nov 5, 2024
tanmayy24
reviewed
Nov 5, 2024
tanmayy24
reviewed
Nov 5, 2024
tanmayy24
reviewed
Nov 5, 2024
tanmayy24
reviewed
Nov 5, 2024
tanmayy24
reviewed
Nov 5, 2024
tanmayy24
reviewed
Nov 5, 2024
Thank you! Looks good to me! |
tanmayy24
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :) In this PR I am migrating some dataset indexes to Zenodo, and updating the data loader modules and tests with the remote mechanics.
Some pending things: