Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.6, adding 3.9 #580

Closed
guillemcortes opened this issue Mar 1, 2023 · 6 comments
Closed

Remove support for Python 3.6, adding 3.9 #580

guillemcortes opened this issue Mar 1, 2023 · 6 comments
Assignees

Comments

@guillemcortes
Copy link
Collaborator

guillemcortes commented Mar 1, 2023

Hi all,

I open this issue as a reference thread for the upcoming PR I'll be doing in which I'll be addressing current mirdata issues (I have @genisplaja green light):

  • Fixing black version to 23.1.0
  • Bump librosa related stuff to use array (so it doesn't break python3.6 support)
  • Fix tox.ini to have the three passenv variables in new lines
  • Mock pandas import at docs/conf.py for sphinx autodoc

Path forward:

  • Support to python3.9 and python3.10 and terminate python 3.6 support.
@guillemcortes
Copy link
Collaborator Author

python3.6 test is failing because black 23.1.0 is not available. Should we terminate python3.6 support in this release?
https://app.circleci.com/pipelines/github/mir-dataset-loaders/mirdata/2651/workflows/8ead522b-aec5-4b06-be1a-3ab8e90c42e3/jobs/9351

@genisplaja
Copy link
Collaborator

genisplaja commented Mar 2, 2023

Maybe we could soften the black version for now? Like black>=22.x.x, so that in python 3.6 we install the old one, and for python 3.7 and 3.8 we install the new one and the tests in circle ci should pass!

@guillemcortes
Copy link
Collaborator Author

But if python 3.6 installs black 22.x.x and python 3.7 installs 23.x.x both tests won't pass because you will have formatted the files at one specific black version so when testing with the other the test will fail. The easiest/quickest option would be to fix black version to the latest available in python3.6 and format the files with it. Python3.7 and 3.8 would also install the same version so the tests won't fail. Maybe we can do this and update the black version to >= 23.1.0 when we terminate py36 support.

@genisplaja
Copy link
Collaborator

oops of course, you're right. Sorry about that :) Yes probably what you suggest is the best option for now, so we can move on with the ongoing PRs, and when we remove support for 3.6 we update black to the 23 version.

@guillemcortes
Copy link
Collaborator Author

great, I'll go ahead, then :)

@genisplaja genisplaja changed the title mirdata multiple fixes Remove support for Python 3.6, adding 3.9 Apr 19, 2023
@genisplaja
Copy link
Collaborator

genisplaja commented Apr 19, 2023

@guillemcortes guillemcortes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants