-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.6, adding 3.9 #580
Comments
python3.6 test is failing because black 23.1.0 is not available. Should we terminate python3.6 support in this release? |
Maybe we could soften the black version for now? Like |
But if python 3.6 installs black 22.x.x and python 3.7 installs 23.x.x both tests won't pass because you will have formatted the files at one specific black version so when testing with the other the test will fail. The easiest/quickest option would be to fix black version to the latest available in python3.6 and format the files with it. Python3.7 and 3.8 would also install the same version so the tests won't fail. Maybe we can do this and update the black version to >= 23.1.0 when we terminate py36 support. |
oops of course, you're right. Sorry about that :) Yes probably what you suggest is the best option for now, so we can move on with the ongoing PRs, and when we remove support for 3.6 we update black to the 23 version. |
great, I'll go ahead, then :) |
|
Hi all,
I open this issue as a reference thread for the upcoming PR I'll be doing in which I'll be addressing current mirdata issues (I have @genisplaja green light):
Path forward:
The text was updated successfully, but these errors were encountered: