Flaky test: AuthenticationSessionTest

Workaround for flaky test AuthenticationSessionTest#testConcurrentAuthenticationSessionsRemoval Closes keycloak#35015 Signed-off-by: Pedro Ruivo <[email protected]>
miquelsi · Nov 25, 2024 · e143b02 · e143b02
1 parent 12436fd
commit e143b02
Showing 1 changed file with 43 additions and 3 deletions.
diff --git a/testsuite/model/src/main/java/org/keycloak/testsuite/model/HotRodServerRule.java b/testsuite/model/src/main/java/org/keycloak/testsuite/model/HotRodServerRule.java
@@ -1,12 +1,23 @@
 package org.keycloak.testsuite.model;
 
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Stream;
+
 import org.infinispan.client.hotrod.RemoteCacheManager;
 import org.infinispan.commons.dataconversion.MediaType;
 import org.infinispan.configuration.cache.BackupConfiguration;
 import org.infinispan.configuration.cache.BackupFailurePolicy;
 import org.infinispan.configuration.cache.CacheMode;
 import org.infinispan.configuration.cache.Configuration;
 import org.infinispan.configuration.cache.ConfigurationBuilder;
+import org.infinispan.container.versioning.IncrementableEntryVersion;
+import org.infinispan.container.versioning.NumericVersion;
+import org.infinispan.container.versioning.VersionGenerator;
+import org.infinispan.factories.ComponentRegistry;
+import org.infinispan.factories.KnownComponentNames;
 import org.infinispan.manager.DefaultCacheManager;
 import org.infinispan.server.hotrod.HotRodServer;
 import org.infinispan.server.hotrod.configuration.HotRodServerConfiguration;
@@ -16,9 +27,6 @@
 import org.keycloak.connections.infinispan.InfinispanUtil;
 import org.keycloak.marshalling.KeycloakModelSchema;
 
-import java.io.IOException;
-import java.util.concurrent.TimeUnit;
-
 import static org.keycloak.connections.infinispan.InfinispanConnectionProvider.ACTION_TOKEN_CACHE;
 import static org.keycloak.connections.infinispan.InfinispanConnectionProvider.AUTHENTICATION_SESSIONS_CACHE_NAME;
 import static org.keycloak.connections.infinispan.InfinispanConnectionProvider.CLIENT_SESSION_CACHE_NAME;
@@ -80,6 +88,9 @@ public void createEmbeddedHotRodServer(Config.Scope config) {
         getCaches(USER_SESSION_CACHE_NAME, OFFLINE_USER_SESSION_CACHE_NAME, CLIENT_SESSION_CACHE_NAME, OFFLINE_CLIENT_SESSION_CACHE_NAME,
                 LOGIN_FAILURE_CACHE_NAME, WORK_CACHE_NAME, ACTION_TOKEN_CACHE, AUTHENTICATION_SESSIONS_CACHE_NAME);
 
+        replaceVersionGenerator(USER_SESSION_CACHE_NAME, OFFLINE_USER_SESSION_CACHE_NAME, CLIENT_SESSION_CACHE_NAME, OFFLINE_CLIENT_SESSION_CACHE_NAME,
+                LOGIN_FAILURE_CACHE_NAME, WORK_CACHE_NAME, ACTION_TOKEN_CACHE, AUTHENTICATION_SESSIONS_CACHE_NAME);
+
         // Use Keycloak time service in remote caches
         InfinispanUtil.setTimeServiceToKeycloakTime(hotRodCacheManager);
         InfinispanUtil.setTimeServiceToKeycloakTime(hotRodCacheManager2);
@@ -92,6 +103,35 @@ private void getCaches(String... cache) {
         }
     }
 
+    // ----- WORKAROUND FOR https://github.com/infinispan/infinispan/issues/13191 -----//
+    private void replaceVersionGenerator(String... caches) {
+        Arrays.stream(caches)
+                .flatMap(name -> Stream.of(hotRodCacheManager.getCache(name), hotRodCacheManager2.getCache(name)))
+                .map(ComponentRegistry::of)
+                .forEach(cr -> cr.registerComponent(RANDOM_GENERATOR, KnownComponentNames.HOT_ROD_VERSION_GENERATOR, false));
+    }
+
+    private static final NumericVersion NON_EXISTING = new NumericVersion(0);
+    private static final VersionGenerator RANDOM_GENERATOR = new VersionGenerator() {
+        @Override
+        public IncrementableEntryVersion generateNew() {
+            var version = ThreadLocalRandom.current().nextLong();
+            return version == 0 ? new NumericVersion(1L) : new NumericVersion(version);
+        }
+
+        @Override
+        public IncrementableEntryVersion increment(IncrementableEntryVersion initialVersion) {
+            // not used by hot rod
+            throw new IllegalStateException();
+        }
+
+        @Override
+        public IncrementableEntryVersion nonExistingVersion() {
+            return NON_EXISTING;
+        }
+    };
+    // ----- END OF WORKAROUND -----//
+
     private void createKeycloakCaches(boolean async, String... cache) {
         ConfigurationBuilder sessionConfigBuilder1 = createCacheConfigurationBuilder();
         ConfigurationBuilder sessionConfigBuilder2 = createCacheConfigurationBuilder();