Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Common open ports are not reported as findings #543

Closed
zcrt opened this issue Mar 22, 2023 · 2 comments · Fixed by #734
Closed

[Bug] Common open ports are not reported as findings #543

zcrt opened this issue Mar 22, 2023 · 2 comments · Fixed by #734
Labels
bug Something isn't working

Comments

@zcrt
Copy link
Contributor

zcrt commented Mar 22, 2023

Describe the bug
Common ports such as 443 do not end up in KATs findings. However, not every service with port 443 open was also intended to have that port reachable by KAT. In a report, as an end-user I want to know all open ports that KAT has found.

To Reproduce
Steps to reproduce the behavior:

  1. Scan a website
  2. Generate a report
  3. There is no finding for a common open port

Expected behavior
Report all open ports seen by KAT.

OpenKAT version
c799f18 (latest)

Additional context

if port not in COMMON_TCP_PORTS and port not in SA_PORTS and port not in DB_PORTS:

@zcrt zcrt added the bug Something isn't working label Mar 22, 2023
@underdarknl
Copy link
Contributor

There are two ways for this to be done.
The first would be to move the various lists of ports from inside the BIT, to inside the graph, where they can be added/changed by users. The Bit would then look for this ConfigOOI and match ports listed there against the ports seen on an IP. This would also allow more fine-grained control of these settings, as you could bind a ConfigOOI to a Network, but also directly to an IPAddress to make specific changes based on your requirements. Following that would allow you to have more or less findings based on your config.

The second would be to include all ports in the report you are looking at. Since all known ports are present in the Graph, we could just include them in the query that produces the report. This for the moment is a bit too complex, but is something that would become much easier when octopoesV3 becomes available.

@zcrt
Copy link
Contributor Author

zcrt commented Mar 24, 2023

I would opt for the second option as I always want to know all ports that are open on all IPs I scan with KAT. Why is it complex at the moment? It is already possible to filter on IPPort on the object page, so adding similar logic to all reports should be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants