Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Pydantic v2 #1841

Closed
ammar92 opened this issue Sep 28, 2023 · 0 comments · Fixed by #1912
Closed

Upgrade to Pydantic v2 #1841

ammar92 opened this issue Sep 28, 2023 · 0 comments · Fixed by #1912
Assignees
@underdarknl @ammar92
Labels
dependencies Pull requests that update a dependency file python tech-debt
Milestone
OpenKAT v1.14

Comments

@ammar92
Copy link
Contributor

ammar92 commented Sep 28, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Pydantic v2 is the new default and offers better performance and new features. See also #1815

Describe the solution you'd like
Upgrade Pydantic package

Describe alternatives you've considered
Update Pydantic and use pydantic.v1 module for code that can't be easily migrated yet.

Additional context
See migration guide and also these points are relevant for upgrading specifically for this code base:

  • Some field and method changes in BaseModel
  • Model config changed (now a dictionary instead of a class)
  • @validator and @root_validator are deprecated
  • pydantic.generics.GenericModel is removed
  • Changes in Required, optional, and nullable fields
  • TypeAdapter may make root models unnecessary
  • BaseSettings has moved to pydantic-settings
@ammar92 ammar92 added dependencies Pull requests that update a dependency file python tech-debt labels Sep 28, 2023
@ammar92 ammar92 added this to KAT Sep 28, 2023
@github-project-automation github-project-automation bot moved this to Incoming features / Need assessment in KAT Sep 28, 2023
@TwistMeister TwistMeister moved this from Incoming features / Need assessment to Todo (In this sprint) in KAT Sep 28, 2023
@ammar92 ammar92 self-assigned this Sep 28, 2023
@ammar92 ammar92 moved this from Todo (In this sprint) to In Progress in KAT Oct 1, 2023
@underdarknl underdarknl mentioned this issue Oct 2, 2023
Closed
@dekkers dekkers added this to the OpenKAT v1.14 milestone Oct 10, 2023
@ammar92 ammar92 mentioned this issue Oct 17, 2023
Merged
7 tasks
@ammar92 ammar92 moved this from In Progress to Review in KAT Oct 17, 2023
@Donnype Donnype moved this from Review to In Progress in KAT Oct 18, 2023
@ammar92 ammar92 moved this from In Progress to Review in KAT Oct 24, 2023
@TwistMeister TwistMeister moved this from Review to In Progress in KAT Oct 31, 2023
@Rieven Rieven moved this from In Progress to Ready for merge in KAT Nov 30, 2023
@github-project-automation github-project-automation bot moved this from Ready for merge to Done in KAT Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@underdarknl underdarknl

@ammar92 ammar92

Labels
dependencies Pull requests that update a dependency file python tech-debt
Projects
KAT
Archived in project
Milestone
OpenKAT v1.14
Development

Successfully merging a pull request may close this issue.

Upgrade to Pydantic v2 minvws/nl-kat-coordination
3 participants
@dekkers @underdarknl @ammar92