From d4f2d3bf9335d8f9c61a5063a9bcb0d9ed24bc75 Mon Sep 17 00:00:00 2001 From: Ben van Eekelen Date: Mon, 11 Dec 2023 19:00:25 +0100 Subject: [PATCH] fix: set OS and NodeJS version to use in GitHub workflow (#4945) * fix: set version hard * fix: set version hardcoded on all other workflow files * fix: node * fix: add matrix to all jobs * fix: add use node 18.18.2 * fix: Remove unused use-node 18.18.2 * fix: Set ubuntu version to 22.04 and node version to 18.18.2 * fix: remove Os --- .github/workflows/codeql-analysis.yml | 8 ++++- .github/workflows/infra-acceptance.yml | 2 +- .github/workflows/infra-develop.yml | 2 +- .github/workflows/infra.yml | 2 +- .github/workflows/main.yml | 34 ++++++++++++++++++---- .github/workflows/sync-sanity-lokalize.yml | 10 ++++++- 6 files changed, 48 insertions(+), 10 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index e03c596358..bdae86da83 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -23,7 +23,7 @@ on: jobs: analyze: name: Analyze - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 permissions: actions: read contents: read @@ -32,6 +32,7 @@ jobs: strategy: fail-fast: false matrix: + node-version: [ 18.18.2 ] language: ['javascript'] # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ] # Learn more: @@ -41,6 +42,11 @@ jobs: - name: Checkout repository uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v2 + with: + node-version: ${{ matrix.node-version }} + # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL uses: github/codeql-action/init@v1 diff --git a/.github/workflows/infra-acceptance.yml b/.github/workflows/infra-acceptance.yml index 784245b443..10850a9cb9 100644 --- a/.github/workflows/infra-acceptance.yml +++ b/.github/workflows/infra-acceptance.yml @@ -10,7 +10,7 @@ jobs: trigger-acceptance-build: environment: Acceptance name: Call Azure Pipeline - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Azure Pipelines Action uses: Azure/pipelines@v1.2 diff --git a/.github/workflows/infra-develop.yml b/.github/workflows/infra-develop.yml index 659ee62c57..3615ca04a2 100644 --- a/.github/workflows/infra-develop.yml +++ b/.github/workflows/infra-develop.yml @@ -8,7 +8,7 @@ jobs: trigger-develop-build: environment: Development name: Call Azure Pipeline - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Azure Pipelines Action uses: Azure/pipelines@v1 diff --git a/.github/workflows/infra.yml b/.github/workflows/infra.yml index 91c7a95be0..ed78ceb791 100644 --- a/.github/workflows/infra.yml +++ b/.github/workflows/infra.yml @@ -8,7 +8,7 @@ on: jobs: build: name: Call Azure Pipeline - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Azure Pipelines Action uses: Azure/pipelines@v1 diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 66e036fc43..8fdf111530 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -4,7 +4,7 @@ on: pull_request jobs: init: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Cancel previous workflow uses: styfle/cancel-workflow-action@0.4.0 @@ -12,12 +12,20 @@ jobs: access_token: ${{ github.token }} lint: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 + strategy: + matrix: + node-version: [18.18.2] needs: init steps: - name: Check out repository uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v2 + with: + node-version: ${{ matrix.node-version }} + - name: Get yarn cache directory path id: yarn-cache-dir-path run: echo "::set-output name=dir::$(yarn config get cacheFolder)" @@ -38,7 +46,10 @@ jobs: run: yarn lint compile: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 + strategy: + matrix: + node-version: [18.18.2] needs: init steps: - name: Get target branch name (pull request) @@ -49,6 +60,11 @@ jobs: - name: Check out repository uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v2 + with: + node-version: ${{ matrix.node-version }} + - name: Get yarn cache directory path id: yarn-cache-dir-path run: echo "::set-output name=dir::$(yarn config get cacheFolder)" @@ -83,12 +99,20 @@ jobs: run: yarn typecheck test: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 + strategy: + matrix: + node-version: [18.18.2] needs: init steps: - name: Check out repository uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v2 + with: + node-version: ${{ matrix.node-version }} + - name: Get yarn cache directory path id: yarn-cache-dir-path run: echo "::set-output name=dir::$(yarn config get cacheFolder)" @@ -118,7 +142,7 @@ jobs: run: yarn test:ci docker: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 needs: init if: contains(github.head_ref, 'release') steps: diff --git a/.github/workflows/sync-sanity-lokalize.yml b/.github/workflows/sync-sanity-lokalize.yml index 543224259c..e4f275ce5a 100644 --- a/.github/workflows/sync-sanity-lokalize.yml +++ b/.github/workflows/sync-sanity-lokalize.yml @@ -7,11 +7,19 @@ on: jobs: sync-after-feature: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 + strategy: + matrix: + node-version: [18.18.2] steps: - name: Check out repository uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v2 + with: + node-version: ${{ matrix.node-version }} + - name: Get yarn cache directory path id: yarn-cache-dir-path run: echo "::set-output name=dir::$(yarn config get cacheFolder)"