Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom margin is too small #69

Closed
oyvindskaaden opened this issue Oct 12, 2024 · 6 comments · Fixed by #73
Closed

Bottom margin is too small #69

oyvindskaaden opened this issue Oct 12, 2024 · 6 comments · Fixed by #73
Assignees
Labels
bug Something isn't working

Comments

@oyvindskaaden
Copy link

Describe the bug
The bottom margin is too small. Content interferes with the footer.

To Reproduce
Steps to reproduce the behavior:

  1. Make enough entries to fill more than one page.

Expected behavior
I would expect the content to do a pagebreak before reaching the footer.

Screenshots
image

Desktop (please complete the following information):

  • OS: MacOS 14
  • Browser Firefox
  • Version v130

Typst Web Editor
Typst version: 0.11.1

Additional context
Could be added into the metadata.toml

@oyvindskaaden
Copy link
Author

I have found that changing the margins to

margin: (left: 1.4cm, right: 1.4cm, top: 1.0cm, bottom: 1.0cm)

the pagebreaking works correctly.

@mintyfrankie
Copy link
Owner

Hi @oyvindskaaden thanks for reporting this!

Recent version upgrade of v2.0.3 introduced a new way to handle footer, it could be that change interfering with the margin. What is your package version? If it's v2.0.3, could you please roll back to v2.0.2 and tell me if the problem persists?

@oyvindskaaden
Copy link
Author

Hi!

When rolling back to v2.0.2 the footer just dissapairs:
image

It is the same behaviour as v2.0.0 through v2.0.2.

@mintyfrankie
Copy link
Owner

That's weird, are you having a multi-page CV?

I will look into this more in details, thanks for the extra information!

@mintyfrankie mintyfrankie self-assigned this Oct 13, 2024
@mintyfrankie mintyfrankie added the bug Something isn't working label Oct 13, 2024
@mintyfrankie mintyfrankie moved this to Short Term in brilliant-CV Oct 13, 2024
@oyvindskaaden
Copy link
Author

@mintyfrankie Yep, multipage CV.
In v2.0.0 through v2.0.2 the footer appears on the bottom of the last page. In v2.0.3 the footer appears on each page, but the margins are too tight.

Repository owner deleted a comment Oct 24, 2024
@mintyfrankie
Copy link
Owner

Hi thanks for the patience! Finally got the time to sit down and patch this one. I've adopted your values, even though it might eats out two lines but the overall aesthetic seems to be better.

Will package this one for the next version update at Typst repository. Thanks!

@github-project-automation github-project-automation bot moved this from Short Term to Long Term in brilliant-CV Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Long Term
Development

Successfully merging a pull request may close this issue.

2 participants