From 79a9f6f5382632a9413cc18f5e847827e469bd7f Mon Sep 17 00:00:00 2001 From: James Green Date: Mon, 6 Jan 2025 15:56:41 +0000 Subject: [PATCH 1/2] remove hard coded arn --- modules/dns/ecs_task_definition.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/dns/ecs_task_definition.tf b/modules/dns/ecs_task_definition.tf index 17c0e811..cdf138e6 100644 --- a/modules/dns/ecs_task_definition.tf +++ b/modules/dns/ecs_task_definition.tf @@ -43,7 +43,7 @@ resource "aws_ecs_task_definition" "server_task" { }, { "name": "DNS_HEALTH_CHECK_URL", - "valueFrom": "arn:aws:ssm:eu-west-2:068084030754:parameter/DNS_HEALTH_CHECK_URL" + "valueFrom": "${var.ssm_arns["DNS_HEALTH_CHECK_URL"]}" } ], "image": "${module.dns_dhcp_common.ecr.repository_url}", From 767814afb5af88b44a28dc4cdfc170d3e4ef5376 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 6 Jan 2025 15:58:22 +0000 Subject: [PATCH 2/2] Commit changes made by code formatters --- environment.dns.tf | 6 +++--- locals.tf | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/environment.dns.tf b/environment.dns.tf index 695394d2..a325821d 100644 --- a/environment.dns.tf +++ b/environment.dns.tf @@ -15,7 +15,7 @@ resource "aws_secretsmanager_secret_version" "staff_device_dns_sentry_dsn" { resource "aws_ssm_parameter" "dns_health_check_url" { provider = aws.env - name = "DNS_HEALTH_CHECK_URL" - type = "String" - value = "gov.uk" + name = "DNS_HEALTH_CHECK_URL" + type = "String" + value = "gov.uk" } diff --git a/locals.tf b/locals.tf index feb1613f..92dbfb32 100644 --- a/locals.tf +++ b/locals.tf @@ -39,7 +39,7 @@ locals { ssm_arns = { - DNS_HEALTH_CHECK_URL = aws_ssm_parameter.dns_health_check_url.arn + DNS_HEALTH_CHECK_URL = aws_ssm_parameter.dns_health_check_url.arn } secret_manager_arns = {