fix(banner): fix issue with classes not working if banner type provided

[AlexBramhill]

Identify the bug

Link to the issue describing the bug that you're fixing.

Description of the change

• Existing implementation appears to have an else and endIf block in a place that disables classes if type is set:

// Existing implementation (spacing added for readability)
<div class=
  "moj-banner
  {% if params.type == 'success' %} moj-banner--success
  {% elif params.type == 'warning' %} moj-banner--warning
  {% else %}           // This else and endIf below cause the bug
  {{- ' ' + params.classes if params.classes}}
  {% endif %}"
  ...
>

• Updated and refactored file to address this bug, and increase readability following pattern of declaring classes logic above component as per recent button-menu commit to main

Alternative designs

• I have a commit on this branch (hash 5742f092b7cc670d6ab453459f03c1252964d07e) that does not do the refactor, but addresses the bug

Possible drawbacks

If this is an intended business logic, then this change is not needed.

Verification process

Manual testing:

• check can set type and component reflects this
• check can set classes and component reflects this
• check can set type and classes and component reflects this
• check if type and classes contradict, type takes precedence

Release notes

Fixed #886 where if a banner type is present, banner classes could not be set

[chrispymm]

Thanks for the PR. I'm pretty sure this is a bug and not intended behaviour.

Changes look good and the refactor is nice too.

Spotted one issue, where I think you're missing set. If you can fix that up, then I can get this merged.

[gregtyler]

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀