Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the different versions of Go & dependencies used across unit tests. #7613

Closed
2 tasks done
mikereiddigital opened this issue Jul 31, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
go Pull requests that update Go code

Comments

@mikereiddigital
Copy link
Contributor

mikereiddigital commented Jul 31, 2024

User Story

As a Modernisation Platform Engineer

I want our Go/Terratest Unit Tests to use the right version of Go and have dependencies that are up to date for the version used.

This PR - ministryofjustice/modernisation-platform-terraform-module-template#424 for the terraform module-template shows the change to dependabot to include Go unit test files in its scope.

Value / Purpose

This will ensure that our tests continue to work & avoid security vulnerabilities due old much older versions being used.

Useful Contacts

No response

Additional Information

No response

Definition of Done

  • Review & agree with team that the issue requires resolution as described above.
  • Roll out across all repositories containing unit tests, ensuring each unit test continues to work correctly after any updates.
@ASTRobinson
Copy link
Contributor

Below are all the PR's to bump Go versions to 1.23 and add the Go Mod dependency check for Dependabot:

ministryofjustice/modernisation-platform-github-oidc-provider#452
ministryofjustice/modernisation-platform-github-oidc-provider#456
ministryofjustice/modernisation-platform-instance-scheduler#1246
ministryofjustice/modernisation-platform-terraform-aws-vm-import#489
ministryofjustice/modernisation-platform-terraform-aws-vm-import#494
ministryofjustice/modernisation-platform-terraform-baselines#607
ministryofjustice/modernisation-platform-terraform-bastion-linux#547
ministryofjustice/modernisation-platform-terraform-bastion-linux#551
ministryofjustice/modernisation-platform-terraform-cross-account-access#436
ministryofjustice/modernisation-platform-terraform-cross-account-access#439
ministryofjustice/modernisation-platform-terraform-dns-certificates#375
ministryofjustice/modernisation-platform-terraform-ec2-autoscaling-group#430
ministryofjustice/modernisation-platform-terraform-ec2-autoscaling-group#433
ministryofjustice/modernisation-platform-terraform-ec2-instance#486
ministryofjustice/modernisation-platform-terraform-ec2-instance#491
ministryofjustice/modernisation-platform-terraform-ecs-cluster#275
ministryofjustice/modernisation-platform-terraform-iam-superadmins#477
ministryofjustice/modernisation-platform-terraform-iam-superadmins#480
ministryofjustice/modernisation-platform-terraform-lambda-function#103
ministryofjustice/modernisation-platform-terraform-lambda-function#118
ministryofjustice/modernisation-platform-terraform-loadbalancer#533
ministryofjustice/modernisation-platform-terraform-loadbalancer#538
ministryofjustice/modernisation-platform-terraform-member-vpc#500
ministryofjustice/modernisation-platform-terraform-member-vpc#504
ministryofjustice/modernisation-platform-terraform-pagerduty-integration#457
ministryofjustice/modernisation-platform-terraform-pagerduty-integration#461
ministryofjustice/modernisation-platform-terraform-s3-bucket#550
ministryofjustice/modernisation-platform-terraform-s3-bucket#553
ministryofjustice/modernisation-platform-terraform-ssm-patching#490
ministryofjustice/modernisation-platform-terraform-ssm-patching#494

@ASTRobinson
Copy link
Contributor

I have checked all the MP repos and enabled Dependabot for Go dependencies and bumped the Go version to 1.23.

Example PR's:
Bump Go Version: ministryofjustice/modernisation-platform-terraform-baselines#607
Enable Dependabot for Go: ministryofjustice/modernisation-platform-github-oidc-provider#452

This was discussed in standup this morning and the team agreed with the implemented solution, passing for review/close.

@dms1981 dms1981 moved this from For Review to Done in Modernisation Platform Oct 17, 2024
@dms1981 dms1981 closed this as completed by moving to Done in Modernisation Platform Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done
Development

No branches or pull requests

4 participants