Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR - Update MP modules to not be region specific #7146

Closed
3 of 4 tasks
davidkelliott opened this issue Jun 4, 2024 · 8 comments
Closed
3 of 4 tasks

DR - Update MP modules to not be region specific #7146

davidkelliott opened this issue Jun 4, 2024 · 8 comments
Assignees
Labels
DR Disaster Recovery terraform Pull requests that update Terraform code terraform-module

Comments

@davidkelliott
Copy link
Contributor

davidkelliott commented Jun 4, 2024

User Story

As an MP user
I want to be able to easily change module regions
So that in a DR situation I can change the region without needing a new module release

Value / Purpose

To make changing regions during a DR scenario as easily as possible.

Useful Contacts

No response

Additional Information

See current DR guidance here which requires regions to be updated in all of our modules - https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/dr-process.html#repo-module-list

Proposal / Unknowns

Proposal

Update modules so that there is an input for the region. The default region should be eu-west-2 (or whatever the module currently uses) so that it isn't a breaking change.

This region can then be set once at a member account level and easily changed.

Definition of Done

  • Modules updated to accept different regions (with current region as default)
  • User docs have been updated
  • Another team member has reviewed
  • Tests are green
@dms1981
Copy link
Contributor

dms1981 commented Jul 18, 2024

This might just be a question of assessing what resources are region-specific, because the region to build a thing in is based on the provider, not a variable in a resource (generally!).

@dms1981
Copy link
Contributor

dms1981 commented Jul 18, 2024

Further to my previous, the scope here is all of our modules. That's a lot of modules.

@dms1981 dms1981 added terraform Pull requests that update Terraform code terraform-module labels Jul 18, 2024
@ep-93 ep-93 self-assigned this Oct 3, 2024
@ep-93
Copy link
Contributor

ep-93 commented Oct 3, 2024

@ep-93
Copy link
Contributor

ep-93 commented Oct 4, 2024

Fixed one, looking now at config management

https://github.com/search?q=repo%3Aministryofjustice%2Fmodernisation-platform-configuration-management%20%20eu-west-2&type=code

yml files have it hardcoded in.

@ep-93
Copy link
Contributor

ep-93 commented Oct 8, 2024

Docs PR = #8192

@mikereiddigital
Copy link
Contributor

Hi @ep-93 if you confirm the DoDs are done I will review :)

@ep-93
Copy link
Contributor

ep-93 commented Oct 10, 2024

Docs have been merged in, ready for review.

@ep-93 ep-93 closed this as completed Oct 10, 2024
@github-project-automation github-project-automation bot moved this from For Review to Done in Modernisation Platform Oct 10, 2024
@ep-93 ep-93 reopened this Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Done to To Do in Modernisation Platform Oct 10, 2024
@mikereiddigital
Copy link
Contributor

Have reviewed the changes & will move to done.

@mikereiddigital mikereiddigital closed this as completed by moving to Done in Modernisation Platform Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DR Disaster Recovery terraform Pull requests that update Terraform code terraform-module
Projects
Status: Done
Development

No branches or pull requests

4 participants