Remove Terraform depreciation warning

[davidkelliott]

User Story

Warning: Argument is deprecated

  with provider["registry.terraform.io/hashicorp/aws"].modernisation-platform,
  on providers.tf line 19, in provider "aws":
  19:   skip_get_ec2_platforms = true

With the retirement of EC2-Classic the skip_get_ec2_platforms attribute has
been deprecated and will be removed in a future version.

Note this was added to resolve a permissions issue, check that this issue has been resolved when removing this from a platform.

User Type(s)

Value

Questions / Assumptions / Hypothesis

Definition of done

• readme has been updated
• user docs have been updated
• another team member has reviewed
• tests are green
• UR test OR added to continual research plan

Reference

How to write good user stories

[davidkelliott]

ministryofjustice/modernisation-platform-environments#1179
ministryofjustice/modernisation-platform-environments#1176
ministryofjustice/modernisation-platform-github-oidc-provider#23
ministryofjustice/modernisation-platform-github-oidc-role#13
ministryofjustice/modernisation-platform-terraform-aws-vm-import#29
ministryofjustice/modernisation-platform-terraform-lambda-function#13
ministryofjustice/modernisation-platform-terraform-loadbalancer#25
ministryofjustice/modernisation-platform-terraform-module-template#24
ministryofjustice/modernisation-platform-terraform-pagerduty-integration#17
ministryofjustice/modernisation-platform-terraform-s3-bucket#50
ministryofjustice/modernisation-platform-terraform-s3-bucket-replication-role#30
ministryofjustice/modernisation-platform-terraform-ssm-patching#17