Nit 833 (#3338)

* add and rename all ssm params * rm duplicate * lowercase * remove copilotisms * typo :( * path corrections
ministryofjustice · Sep 12, 2023 · 64706bf · 64706bf
1 parent a2f2371
commit 64706bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 20 deletions.
diff --git a/terraform/environments/delius-core/modules/environment_all_components/ldap_params.tf b/terraform/environments/delius-core/modules/environment_all_components/ldap_params.tf
@@ -30,7 +30,7 @@ resource "aws_ssm_parameter" "delius_core_ldap_host" {
 }
 
 resource "aws_ssm_parameter" "delius_core_ldap_principal" {
-  name  = format("/%s-%s/LDAP_PRINCIPLE", var.account_info.application_name, var.env_name)
+  name  = format("/%s-%s/LDAP_PRINCIPAL", var.account_info.application_name, var.env_name)
   type  = "SecureString"
   value = "INITIAL_VALUE_OVERRIDDEN"
   lifecycle {

diff --git a/terraform/environments/delius-core/modules/environment_all_components/ssm.tf b/terraform/environments/delius-core/modules/environment_all_components/ssm.tf
@@ -67,7 +67,7 @@ resource "aws_ssm_parameter" "oasys_password" {
 }
 
 resource "aws_ssm_parameter" "iaps_user" {
-  name  = format("/%s-%s/iaps_users", var.account_info.application_name, var.env_name)
+  name  = format("/%s-%s/iaps_user", var.account_info.application_name, var.env_name)
   type  = "SecureString"
   value = "INITIAL_VALUE_OVERRIDDEN"
   lifecycle {
@@ -157,7 +157,7 @@ resource "aws_ssm_parameter" "test_user_password" {
 }
 
 resource "aws_ssm_parameter" "delius_core_gdpr_api_client_secret" {
-  name  = format("/%s-%s/gdpr_api_client_secret", var.account_info.application_name, var.env_name)
+  name  = format("/%s-%s/gdpr/api/client_secret", var.account_info.application_name, var.env_name)
   type  = "SecureString"
   value = "INITIAL_VALUE_OVERRIDDEN"
 
@@ -171,7 +171,7 @@ resource "aws_ssm_parameter" "delius_core_gdpr_api_client_secret" {
 }
 
 resource "aws_ssm_parameter" "delius_core_pwm_config_password" {
-  name  = format("/%s-%s/pwm_config_password", var.account_info.application_name, var.env_name)
+  name  = format("/%s-%s/pwm/pwm/config_password", var.account_info.application_name, var.env_name)
   type  = "SecureString"
   value = "INITIAL_VALUE_OVERRIDDEN"
 
@@ -185,7 +185,7 @@ resource "aws_ssm_parameter" "delius_core_pwm_config_password" {
 }
 
 resource "aws_ssm_parameter" "delius_core_merge_api_client_secret" {
-  name  = format("/%s-%s/merge_api_client_secret", var.account_info.application_name, var.env_name)
+  name  = format("/%s-%s/merge/api/client_secret", var.account_info.application_name, var.env_name)
   type  = "SecureString"
   value = "INITIAL_VALUE_OVERRIDDEN"
 
@@ -199,21 +199,7 @@ resource "aws_ssm_parameter" "delius_core_merge_api_client_secret" {
 }
 
 resource "aws_ssm_parameter" "delius_core_weblogic_ndelius_domain_umt_client_secret" {
-  name  = format("/%s-%s/umt_client_secret", var.account_info.application_name, var.env_name)
-  type  = "SecureString"
-  value = "INITIAL_VALUE_OVERRIDDEN"
-
-  lifecycle {
-    ignore_changes = [
-      value
-    ]
-  }
-
-  tags = local.tags
-}
-
-resource "aws_ssm_parameter" "delius_core_weblogic_ndelius_domain_umt_client_id" {
-  name  = format("/%s-%s/umt_client_id", var.account_info.application_name, var.env_name)
+  name  = format("/%s-%s/weblogic/ndelius-domain/umt_client_secret", var.account_info.application_name, var.env_name)
   type  = "SecureString"
   value = "INITIAL_VALUE_OVERRIDDEN"