You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
I just tried to use this gem, and got a javascript error because our project doesn’t use jQuery. I've created a separate PR (#22) to add a note about this to the README, however I think it might be worth considering one of the following:
rewriting the javascript to not require jQuery (this would be my preference, and it’s not a huge job)
adding a dependency on the jquery-rails gem to the Gemspec (pros: makes the dependency explicit, cons: means people have to use the jQuery gem, even if they don't want to use jQuery, or want to include it via some other mechanism).
adding some detection of jQuery within the javascript (via something like if (typeof jQuery != 'undefined')) to avoid raising errors if it isn’t (maybe log a warning instead).
The text was updated successfully, but these errors were encountered:
Thanks for raising this issue. I agree we should really remove the jQuery dependency. I'll take a look at removing the jQuery dependency and add some tests too.
I just tried to use this gem, and got a javascript error because our project doesn’t use jQuery. I've created a separate PR (#22) to add a note about this to the README, however I think it might be worth considering one of the following:
jquery-rails
gem to the Gemspec (pros: makes the dependency explicit, cons: means people have to use the jQuery gem, even if they don't want to use jQuery, or want to include it via some other mechanism).if (typeof jQuery != 'undefined')
) to avoid raising errors if it isn’t (maybe log a warning instead).The text was updated successfully, but these errors were encountered: