-
Notifications
You must be signed in to change notification settings - Fork 45
review a pull request
Todd Tyree edited this page Jul 16, 2018
·
8 revisions
There are a number of different ways to do this. However, this is the way we want it done in Platform:
- Are there tests? If so, do they pass?
- Don't review anything that has failing tests-ask the PR owner to fix the tests first.
- Does the PR have a description?
- PRs should always have a description summarising its context. Why has the PR been raised and what issue does it address?
- Is there an issue for this PR in Github?
- Generally speaking, PRs should always be linked to specific issues. The issue should be linked or mentioned in the description.