From 1d9a5ea0e2461775582c68d90261c18154ce055a Mon Sep 17 00:00:00 2001 From: jaskaransarkaria Date: Wed, 13 Dec 2023 16:20:50 +0000 Subject: [PATCH 1/2] =?UTF-8?q?fix:=20=F0=9F=90=9B=20broken=20page?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../source/node-group-changes.html.md.erb | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/runbooks/source/node-group-changes.html.md.erb b/runbooks/source/node-group-changes.html.md.erb index 34665915..8e27cd9a 100644 --- a/runbooks/source/node-group-changes.html.md.erb +++ b/runbooks/source/node-group-changes.html.md.erb @@ -1,33 +1,35 @@ --- title: Handling Node Group and Instance Changes weight: 54 -last_reviewed_on: 2023-13-12 +last_reviewed_on: 2023-12-13 review_in: 6 months --- -# <%= current_page.data.title %> +# Making changes to EKS node groups or instances types ## Why? -You may need to make a change to an EKS [cluster-node-group] or [instance-type-config]. We can't just let terraform apply these changes because terraform doesn't gracefully rollout the old and new nodes. Terraform will bring down all of the old nodes immediately, which will cause outages to users. +You may need to make a change to an EKS [cluster node group] or [instance type config]. We can't just let terraform apply these changes because terraform doesn't gracefully rollout the old and new nodes. Terraform will bring down all of the old nodes immediately, which will cause outages to users. ## How? The method to avoid bringing down all the nodes at once is to follow these steps: -1. add a new node group with your [updated-changes] +1. add a new node group with your [updated changes] 1. lookup the old node group name (you can find this in the aws gui) -1. once merged in you can drain the old node group using the following command: -> cloud-platform pipeline cordon-and-drain --cluster-name --node-group -1. raise a new [pr-deleting] the old node group +1. once merged in you can drain the old node group using the command below: +1. raise a new [pr deleting] the old node group + +> ```cloud-platform pipeline cordon-and-drain --cluster-name --node-group ``` + notes: - When making changes to the default node group in live, it's handy to pause the pipelines for each of our environments for the duration of the change. - the `cloud-platform pipeline` command [cordons-and-drains-nodes] in a given node group waiting 2mins between each drained node. This command runs remotely in concourse. -[cluster-node-group]: https://github.com/ministryofjustice/cloud-platform-infrastructure/blob/97768bfd8b4e25df6f415035acac60cf531d88c1/terraform/aws-accounts/cloud-platform-aws/vpc/eks/cluster.tf#L60 -[instance-type-config]: https://github.com/ministryofjustice/cloud-platform-infrastructure/blob/97768bfd8b4e25df6f415035acac60cf531d88c1/terraform/aws-accounts/cloud-platform-aws/vpc/eks/cluster.tf#L43 -[pr-deleting]: https://github.com/ministryofjustice/cloud-platform-infrastructure/pull/2663 -[updated-changes]: https://github.com/ministryofjustice/cloud-platform-infrastructure/pull/2657 -[cordons-and-drains-nodes]: https://github.com/ministryofjustice/cloud-platform-terraform-concourse/blob/main/pipelines/manager/main/cordon-and-drain-nodes.yaml +[cluster node group]: https://github.com/ministryofjustice/cloud-platform-infrastructure/blob/97768bfd8b4e25df6f415035acac60cf531d88c1/terraform/aws-accounts/cloud-platform-aws/vpc/eks/cluster.tf#L60 +[instance type config]: https://github.com/ministryofjustice/cloud-platform-infrastructure/blob/97768bfd8b4e25df6f415035acac60cf531d88c1/terraform/aws-accounts/cloud-platform-aws/vpc/eks/cluster.tf#L43 +[pr deleting]: https://github.com/ministryofjustice/cloud-platform-infrastructure/pull/2663 +[updated changes]: https://github.com/ministryofjustice/cloud-platform-infrastructure/pull/2657 +[cordons and drains nodes]: https://github.com/ministryofjustice/cloud-platform-terraform-concourse/blob/main/pipelines/manager/main/cordon-and-drain-nodes.yaml From 71ee0e0cd06ea16f9f7293ec5dbe376d7f95cf8c Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Wed, 13 Dec 2023 16:21:40 +0000 Subject: [PATCH 2/2] Commit changes made by code formatters --- runbooks/source/node-group-changes.html.md.erb | 1 - 1 file changed, 1 deletion(-) diff --git a/runbooks/source/node-group-changes.html.md.erb b/runbooks/source/node-group-changes.html.md.erb index 8e27cd9a..946eb9f1 100644 --- a/runbooks/source/node-group-changes.html.md.erb +++ b/runbooks/source/node-group-changes.html.md.erb @@ -22,7 +22,6 @@ The method to avoid bringing down all the nodes at once is to follow these steps > ```cloud-platform pipeline cordon-and-drain --cluster-name --node-group ``` - notes: - When making changes to the default node group in live, it's handy to pause the pipelines for each of our environments for the duration of the change.