Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecarImage.repository is not overridable without also pinning sidecarImage.tag #2369

Open
rorynickolls-skyral opened this issue Dec 18, 2024 · 0 comments

Comments

@rorynickolls-skyral
Copy link

Expected Behavior

When overriding the sidecarImage.repository value, it pulls the latest version of the sidecar image from an alternative registry.

Current Behavior

The sidecarImage.repository value cannot be set alone as it leaves the tag field empty, resulting in the pulled image becoming: my-custom-registry/quay-io/minio/operator-sidecar: and causing errors.

This requires the tag to be pinned, meaning that any Helm charts using this as a dependency need an additional process to keep the tag up-to-date.

Possible Solution

If sidecarImage.tag is not set, fall back to using image.tag for the main operator image.

Steps to Reproduce (for bugs)

  1. Set sidecarImage.repository in values but not sidecarImage.tag
  2. See resulting image pull fail with no tag when installed.

Context

We are using a Helm chart that bundles the MinIO operator and a tenant together to install in one go.

This chart relies on the upstream charts keeping images up-to-date, so to pick up the latest version we can just bump the chart.

Without this change, we will have to bump sidecarImage.tag in our own values overrides whenever the chart updates.

Regression

No

Your Environment

  • Version used (minio-operator): 6.0.4
  • Environment name and version (e.g. kubernetes v1.17.2): kubernetes v1.30.6
  • Server type and version: v1.30.6-gke.1125000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant