"Bucket already exists" running in a loop in the operator log after successfully creating bucket.

[fouadsemaan]

Expected Behavior

Bucket creation attempts should stop after returned error that it already exists.

Current Behavior

Minio operator continually spews logs that the bucket already exists after initially creating it. The code for creating the bucket (here) when it already exists seems to be continually triggered by the sync function here. The point of confusion is that the tenant status says it's "Initialized" and yet the logs keep spewing the same error over and over again.

This is logged every 5s:

Event(v1.ObjectReference{Kind:"Tenant", Namespace:"default", Name:"default-minio-tenant", UID:"", APIVersion:"minio.min.io/v2", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'BucketsCreated' Buckets already exist

which creates API 4XX errors and hence false positives in our Grafana dashboards.

In fact here is the tenant status:

Normal BucketsCreated 35m minio-operator Buckets created
Normal BucketsCreated 84s (x392 over 35m) minio-operator Buckets already exist

This is a follow up from issue #2006

Possible Solution

Either fix the sync function, i.e. do not call the sync function when nothing has changed or actually check the bucket already exists before attempting to create it here.

Steps to Reproduce (for bugs)

Context

Regression

Your Environment

• Version used (minio-operator): 5.0.13
• Environment name and version (e.g. kubernetes v1.17.2): 1.27
• Server type and version:
• Operating System and version (uname -a):
• Link to your deployment file:

[fouadsemaan]

Thank you! Any chance a tag will be dropped soon?