Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method isVersioningEnabled() #955

Merged
merged 5 commits into from
May 30, 2020
Merged

Add method isVersioningEnabled() #955

merged 5 commits into from
May 30, 2020

Conversation

sinhaashish
Copy link
Contributor

@sinhaashish sinhaashish commented May 27, 2020 •
edited
Loading

Added the isVersioningEnabled which return true if bucket is version enabled.

@sinhaashish sinhaashish force-pushed the get-bucket-version-config branch 4 times, most recently from 479614e to e484e1a Compare May 28, 2020 15:45
@sinhaashish sinhaashish changed the title add builder to get bucket version status Add builder to get bucket version status May 28, 2020
balamurugana
balamurugana reviewed May 28, 2020
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix comment message and PR title that you are adding new method isVersioningEnabled()

api/src/main/java/io/minio/MinioClient.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/MinioClient.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/messages/VersioningConfiguration.java Show resolved Hide resolved
api/src/main/java/io/minio/messages/VersioningConfiguration.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/messages/VersioningConfiguration.java Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
@sinhaashish sinhaashish changed the title Add builder to get bucket version status Add isVersioningEnabled api using builder May 28, 2020
@sinhaashish sinhaashish changed the title Add isVersioningEnabled api using builder Add method isVersioningEnabled() May 28, 2020
@sinhaashish sinhaashish changed the title Add method isVersioningEnabled() Add method isVersioningEnabled() May 28, 2020
@sinhaashish sinhaashish force-pushed the get-bucket-version-config branch from e484e1a to 29dc355 Compare May 29, 2020 05:15
balamurugana
balamurugana approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

balamurugana
balamurugana requested changes May 29, 2020
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example

@sinhaashish
Copy link
Contributor Author

Please add an example

Added.

@sinhaashish sinhaashish force-pushed the get-bucket-version-config branch from 9757955 to 4c0a860 Compare May 29, 2020 09:51
balamurugana
balamurugana previously approved these changes May 29, 2020
View reviewed changes
@sinhaashish sinhaashish force-pushed the get-bucket-version-config branch from 4c0a860 to a8df66a Compare May 29, 2020 12:18
anjalshireesh
anjalshireesh previously approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a very minor comment.

functional/FunctionalTest.java Outdated Show resolved Hide resolved
@sinhaashish sinhaashish force-pushed the get-bucket-version-config branch from a8df66a to 6639ef2 Compare May 29, 2020 13:04
balamurugana
balamurugana reviewed May 29, 2020
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
@sinhaashish sinhaashish force-pushed the get-bucket-version-config branch from 75bd1fd to 69e4ac8 Compare May 29, 2020 13:55
balamurugana
balamurugana previously approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinhaashish sinhaashish force-pushed the get-bucket-version-config branch from 1f5cb76 to 57b1310 Compare May 29, 2020 15:00
anjalshireesh
anjalshireesh approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

balamurugana
balamurugana reviewed May 30, 2020
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit d6bc4ec into minio:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana approved these changes

@anjalshireesh anjalshireesh anjalshireesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sinhaashish @anjalshireesh @balamurugana @kannappanr