Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix makeBucket() with object-lock functional test #942

Conversation

balamurugana
Copy link
Member

As minio server FS mode recently changed to return NotImplemented
error for CreateBucket with object-lock-enabled, this patch fixes
makeBucket() with object-lock functional test to handle the error
appropriately.

sinhaashish
sinhaashish previously approved these changes May 18, 2020
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As minio server FS mode recently changed to return `NotImplemented`
error for `CreateBucket` with object-lock-enabled, this patch fixes
makeBucket() with object-lock functional test to handle the error
appropriately.
@balamurugana balamurugana force-pushed the fix-makeBucket-with-object-lock-functional-test branch from 6d2bc93 to 3a6dda8 Compare May 18, 2020 05:20
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana changed the title fix makeBucket() with object-lock in functional test fix makeBucket() with object-lock functional test May 18, 2020
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 8d139d4 into minio:master May 18, 2020
@balamurugana balamurugana deleted the fix-makeBucket-with-object-lock-functional-test branch May 18, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants