add arg builder to {set,get,delete}DefaultRetention APIs #935
Conversation
| MinioClient s3Client = | ||
| new MinioClient("https://s3.amazonaws.com", "YOUR-ACCESSKEYID", "YOUR-SECRETACCESSKEY"); | ||
|
|
||
| ObjectLockConfiguration config = |
There was a problem hiding this comment.
IMO we should have a complete example, like creating the bucket, setting the default retention and then fetching it. So that user just have to edit the credentials and run the file.
There was a problem hiding this comment.
I think we need to be specific to examples for an API. Its not possible to run any example without modifying essentials like endpoint, credentials, bucket/object names, respective variables etc and some operations are chargeable in some service providers.
We wouldn't consider examples as tests.
balamurugana
force-pushed
the
add-arg-builder-to-set-get-DefaultRetention-APIs
branch
5 times, most recently
from
cb399ba to
eb5e515
Compare
balamurugana
force-pushed
the
add-arg-builder-to-set-get-DefaultRetention-APIs
branch
8 times, most recently
from
624ae25 to
762df3c
Compare
| } finally { | ||
| client.removeBucket(RemoveBucketArgs.builder().bucket(bucketName).build()); | ||
| } | ||
|
|
||
| mintSuccessLog("getDefaultRetention (String bucketName)", null, startTime); | ||
|
|
||
| mintSuccessLog(methodName, null, startTime); |
There was a problem hiding this comment.
The retention mode and duration can be logged as arguments
There was a problem hiding this comment.
It wouldn't be useful because the failure may happen any one of two checks. I am not favour of mint args because stack trace is the best to find the issue.
There was a problem hiding this comment.
Actually if the try-catch and exception handling is also moved to the new method (testGetDefaultRetention) then the args logging can be done.
balamurugana
force-pushed
the
add-arg-builder-to-set-get-DefaultRetention-APIs
branch
from
762df3c to
98f74f1
Compare
balamurugana
changed the title
| } finally { | ||
| client.removeBucket(RemoveBucketArgs.builder().bucket(bucketName).build()); | ||
| } | ||
|
|
||
| mintSuccessLog("getDefaultRetention (String bucketName)", null, startTime); | ||
|
|
||
| mintSuccessLog(methodName, null, startTime); |
There was a problem hiding this comment.
Actually if the try-catch and exception handling is also moved to the new method (testGetDefaultRetention) then the args logging can be done.
balamurugana
force-pushed
the
add-arg-builder-to-set-get-DefaultRetention-APIs
branch
from
98f74f1 to
7517d83
Compare
No description provided.