Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arg builder to {set,get,delete}BucketNotification APIs #932

Merged
merged 1 commit into from
Jun 2, 2020
Merged

add arg builder to {set,get,delete}BucketNotification APIs #932

merged 1 commit into from
Jun 2, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@kannappanr kannappanr requested review from sinhaashish and anjalshireesh and removed request for sinhaashish May 14, 2020 09:05
@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketNotification-APIs branch 4 times, most recently from b308751 to 35655a3 Compare May 26, 2020 10:16
@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketNotification-APIs branch 6 times, most recently from fd9d79c to 835ac42 Compare May 29, 2020 05:05
@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketNotification-APIs branch from 835ac42 to a7048ce Compare May 29, 2020 14:16
anjalshireesh
anjalshireesh previously approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketNotification-APIs branch 2 times, most recently from b7de5ec to 60bf836 Compare May 31, 2020 05:22
sinhaashish
sinhaashish previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketNotification-APIs branch from 60bf836 to 4796515 Compare June 1, 2020 15:41
sinhaashish
sinhaashish approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 4e3efb0 into minio:master Jun 2, 2020
@balamurugana balamurugana deleted the add-arg-builder-to-set-get-delete-BucketNotification-APIs branch June 2, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@anjalshireesh anjalshireesh anjalshireesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @anjalshireesh @sinhaashish