Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate bucket name, object name. #824

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Validate bucket name, object name. #824

merged 2 commits into from
Dec 9, 2019

Conversation

BigUstad
Copy link
Contributor

@BigUstad BigUstad commented Dec 3, 2019

Fixes #819
Also, checks for other possible errors by looking at header values.

@nitisht nitisht requested review from balamurugana and removed request for nitisht December 4, 2019 15:23
sinhaashish
sinhaashish approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

@nitisht nitisht merged commit 67e26b8 into minio:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@balamurugana balamurugana balamurugana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statObject NPE when object name is empty
4 participants
@BigUstad @balamurugana @sinhaashish @nitisht