Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP endpoint validation error #1974

Closed
ammarhusain-sol opened this issue Jun 24, 2024 · 1 comment
Closed

GCP endpoint validation error #1974

ammarhusain-sol opened this issue Jun 24, 2024 · 1 comment

Comments

@ammarhusain-sol
Copy link
Contributor

ammarhusain-sol commented Jun 24, 2024

While working with GCP if the provided endpoint has a port number for example ("storage.googpleapis.com:443") then the endpoint validation using the function IsGoogleEndpoint() fails and throws an error
"Google Cloud Storage endpoint should be 'storage.googleapis.com'"

In the function IsGoogleEndPoint() there is exact hostname matching happens but in the GO-URL package in the struct URL host contains both hostname and port this causes the error if the provided endpoint has a port.

@ammarhusain-sol
Copy link
Contributor Author

This issue is resolved in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant