Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path encoded in share link url is not url-safe #3304

Closed
cesnietor opened this issue Apr 22, 2024 · 0 comments · Fixed by #3305
Closed

Path encoded in share link url is not url-safe #3304

cesnietor opened this issue Apr 22, 2024 · 0 comments · Fixed by #3305
Assignees
Labels
bug this needs to be fixed community triage

Comments

@cesnietor
Copy link
Collaborator

cesnietor commented Apr 22, 2024

NOTE

If this case is urgent, please subscribe to Subnet so that our 24/7 support team may help you faster.

Expected Behavior

URL should redirect and download files without any issues

Current Behavior

returns a not found since the path contains a / on it e.g.

https://play.min.io:9443/api/v1/download-shared-object/aHR0cHM6Ly8xMjcuMC4wLjE6OTAwMC9jZXN0ZXN0L0F1ZGlvJTIwaWNvbi5zdmc/WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD01U0JFMFlQM0ZXVlFRUDZNNE1IRiUyRjIwMjQwNDIyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQyMlQxODE4MjdaJlgtQW16LUV4cGlyZXM9NDMyMDAmWC1BbXotU2VjdXJpdHktVG9rZW49ZXlKaGJHY2lPaUpJVXpVeE1pSXNJblI1Y0NJNklrcFhWQ0o5LmV5SmhZMk5sYzNOTFpYa2lPaUkxVTBKRk1GbFFNMFpYVmxGUlVEWk5ORTFJUmlJc0ltVjRjQ0k2TVRjeE16ZzBOekU1Tml3aWNHRnlaVzUwSWpvaVVUTkJUVE5WVVRnMk4xTlFVVkZCTkROUU1rWWlmUS5BSXFMQnR4bkVLS0NfUzBJX3RWUEhMODMyZUJwTW95Rkl0el9hWWVEWGF5aFNnNm5YMXhua2dUUjJzbHhnbEhYbUVsTVdUOUJuTk8zQjJscTVVWEVEZyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmdmVyc2lvbklkPW51bGwmWC1BbXotU2lnbmF0dXJlPTA3NjdjM2Q0YWMzNWI4YzFkYWZlMjlmYTEyNGI2NWRiNGNjMDExMmJkNWUyZGZhOGMzZGRlNTQyZDYxYTQ0MzE=

Possible Solution

Steps to Reproduce (for bugs)

  1. Deploy minio on a kubernetes environment
  2. Crete a bucket
  3. Add a png, svg or jpg file
  4. Click share download
  5. URL created adds a /

Context

We recently introduced a change in #3284 which base64 encodes the share link. But when base64 encoding it we don't make sure is url-safe

Regression

Your Environment

  • MinIO version used (minio --version): RELEASE.2024-04-18T19-09-19Z
  • Server setup and configuration:
  • Operating System and version (uname -a):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug this needs to be fixed community triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant