Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving an excel file using FastMode creates an invalid excel file #658

Closed
2 of 4 tasks
Discolai opened this issue Aug 23, 2024 · 1 comment · Fixed by #659
Closed
2 of 4 tasks

Saving an excel file using FastMode creates an invalid excel file #658

Discolai opened this issue Aug 23, 2024 · 1 comment · Fixed by #659

Comments

@Discolai
Copy link
Contributor

Excel Type

  • XLSX
  • XLSM
  • CSV
  • OTHER

MiniExcel Version

  • 1.33
  • 1.34
  • 1.34.1

Description

Saving an excel file with FastMode enabled writes invalid xml. This was introduced in #602 which changed the seeking logic when writing the dimension xml element.
@Discolai
Copy link
Contributor Author

I am working on a fix and will create a pull request shortly

@Discolai Discolai linked a pull request Aug 23, 2024 that will close this issue
Fix dimension writing in FastMode #659
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dimension writing in FastMode Discolai/MiniExcel
1 participant
@Discolai