Fix missing server_id during member normalization in GuildMemberAddPacket #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a new member is added to a server (during the
GuildMemberAddPacket
event), theserver_id
was not being included in the member normalization process. This led to potential errors or inconsistencies during member serialization, particularly when updating the server cache or processing member-related operations.This issue was confirmed by the following error (see screenshot for reference):
Solution
This pull request addresses the issue by explicitly including the
server_id
in the member normalization data. This ensures that the member is properly linked to the correct server, and all subsequent operations, such as updating the server cache or dispatching events, can proceed as expected.The change was implemented by modifying the
listen
method in theGuildMemberAddPacket
class:Changes
Added server_id to the payload during member normalization in GuildMemberAddPacket.
Impact
This fix improves the reliability of member-related events and ensures that the member data is handled properly within the server context. It eliminates errors caused by missing server_id during member processing.