AjaxUploader not actually throwing exceptions

[patriksh]

Osclass/oc-includes/AjaxUploader.php

Line 55 in 070f6f9

public function handleUpload($uploadFilename, $replace = false)

No exceptions are thrown, it just returns an error in an array.
This doesn't trigger the try/catch block in ajax controller.

[navjottomer]

It only has two lines where this can happen, not all errors throw exceptions.

Osclass/oc-includes/AjaxUploader.php

Line 63 in 070f6f9

$size = $this->file->getSize();

Osclass/oc-includes/AjaxUploader.php

Line 90 in 070f6f9

if ($this->file->save($uploadFilename)) {

[patriksh]

But if the image is e.g. too big, the code just continues because an error array is returned and nothing is done with it.

Osclass/oc-includes/osclass/classes/controller/CWebAjax.php

Line 362 in 070f6f9

$result =

[navjottomer]

Hmm, that can be fixed.

[patriksh]

In my api I just made it throw an exception if isset($result['error']).

[navjottomer]

create a pull then I'll merge.

[patriksh]

Can do tomorrow.

[navjottomer]

I also request you to help me clean up https://github.com/mindstellar/shopclass as some of the code is legacy and not needed anymore. In your free time if possible.

[patriksh]

Do you plan to make it the default theme at some point? Not sure how I feel about all the integrated features as a part of a theme.

[navjottomer]

Nope, not default just an alternative. Some features need integration in osclass itself and some need removal altogether. I have created them as some features were not available with osclass nor any plugin was available to provide those features at the time.

[eurobank]

@dftd I highly disagree. Plugins will come maybe late and right now a real theme is needed to PROMOTE the use of Osclass of this release channel.

I think that move from @navjottomer is excellent (to offer this theme for free, since it was NOT free). But apparently some changes are needed to work with 5.1. I can't help coding but i surely can help a lot in testing.

[eurobank]

@navjottomer What happened with the Shopclass theme? Freezed?