Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] GCP Cloud Storage History Backend #72

Closed
GoodmanBen opened this issue Feb 24, 2022 · 6 comments
Closed

[Feature Request] GCP Cloud Storage History Backend #72

GoodmanBen opened this issue Feb 24, 2022 · 6 comments

Comments

@GoodmanBen
Copy link
Contributor

GoodmanBen commented Feb 24, 2022

Current State:
At present, tfmigrate only supports remote storage in Amazon's S3 service. This limits the usage for projects that are based on GCP.

Desired New State:
Support GCP's Cloud Storage as a remote storage service.

@GoodmanBen
Copy link
Contributor Author

GoodmanBen commented Feb 24, 2022

Will follow the pattern recommended by this comment. "Assigning" this issue to myself. Aiming to have an initial pull request available within the coming weeks. Will build off the comments and work done as part of #23.

@minamijoyo
Copy link
Owner

Hi @GoodmanBen, Thank you for offering to take over #23.

As mentioned in #23 (comment), the patch has a license conflict issue and I've been waiting a response from @ethernetdan.

With no reply for months, if you are willing to help with us, it seems that it's time to move forward with you. If I split the history storage related implementation into another repository as MPL2, would you implement the GCC history storage?

@GoodmanBen
Copy link
Contributor Author

@minamijoyo Yes, happy to do so in another repository if that is where you want it to live.

@minamijoyo
Copy link
Owner

Hi @GoodmanBen,

Splitting the history storage related implementation into a new separate repository in MPL2.0 has been done by #79, #80.
https://github.com/minamijoyo/tfmigrate-storage

Feel free to reuse some code snippet from the upstream hashicorp/terraform to implement the gcs storage support.

@GoodmanBen
Copy link
Contributor Author

GoodmanBen commented Mar 26, 2022

Sounds great, thank you for doing this refactor!

@minamijoyo
Copy link
Owner

The gcs history storage has been finally added in v0.3.7 via #103. Thank you all for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants