Fix for previewing on not current window #670
Conversation
| @@ -469,7 +469,7 @@ called from the corresponding command. Note that the options depend on | |||
| the private `consult--read' API and should not be considered as stable | |||
| as the public API.") | |||
|
|
|||
| (defvar consult--buffer-display #'switch-to-buffer | |||
| (defvar consult--buffer-display #'display-buffer | |||
There was a problem hiding this comment.
I'm using e2wm.el and it must support switch-to-buffer.
However, it happens to collapse window layout in my environment.
Anyway, I believe display-buffer is more appropriate for this package role. So, I hope this fix be included
There was a problem hiding this comment.
No, switch-to-buffer is the better choice here. You can set switch-to-buffer-obey-display-actions or change the variable in your configuration. Please change back.
| ;; Handle positions with overlay information | ||
| (consult--with-jump (or (car-safe cand) cand) | ||
| (setq consult--preview-previous-invisibles (consult--invisible-open-temporarily) | ||
| consult--preview-previous-overlays |
There was a problem hiding this comment.
I feel invisible should be defined for not local but global because void variable error happened.
And I changed the name to be more explicit.
Is my understanding wrong?
There was a problem hiding this comment.
Yes, this is wrong. Please revert the change to the overlays/invisibles variable.
|
|
||
| (defun consult--jump (pos) | ||
| "Push current position to mark ring, go to POS and recenter." | ||
| (mapc #'funcall consult--preview-previous-invisibles) | ||
| (mapc #'delete-overlay consult--preview-previous-overlays) |
There was a problem hiding this comment.
it looks like the variables need to be cleared here as well.
And I guess there is a timing that's more appropriate to do this procedure but I couldn't find it.
| ,@body | ||
| (run-hooks 'consult-after-jump-hook)))) | ||
| (if (window-live-p w) | ||
| (with-selected-window w (funcall f)) |
There was a problem hiding this comment.
Here is taking care of the cases like
current-bufferis not the target buffer- the window of the target buffer is not selected window
| (funcall f))))) | ||
|
|
||
| (defvar consult--preview-previous-invisibles nil) | ||
| (defvar consult--preview-previous-overlays nil) |
|
I close this PR in favor of #671. We should first fix consult--buffer-preview to handle display-buffer properly before trying to fix consult--jump-preview. |
consult--jump-previewcould not work with the feature that managesdisplay-buffer-functionlike e2wm.el.That's because
consult--buffer-actiondon't have a consideration for the case thatcurrent-bufferwon't be switched.So, I tried to fix this trouble and it looks to work well with this fix.