Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpSink does not provide start header when full-syncing empty datasets #253

Open
rompetroll opened this issue Sep 5, 2023 · 0 comments
Open

HttpSink does not provide start header when full-syncing empty datasets #253

rompetroll opened this issue Sep 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rompetroll
Copy link
Contributor

rompetroll commented Sep 5, 2023 •
edited
Loading

Since the source never calls its processEntities callback in a fullsync pipeline, the first http request of the full sync protocol, containing the universal-data-api-full-sync-start http header, is never sent.
A final, empty ending request is sent though.

this may confuse recipients, all headers must be sent in a full sync process.
@rompetroll rompetroll changed the title HttpSink does not provide start header when syncing empty datasets HttpSink does not provide start header when full-syncing empty datasets Sep 5, 2023
@rompetroll rompetroll added the bug Something isn't working label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rompetroll