Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failure #118

Closed
wwood opened this issue May 21, 2016 · 4 comments
Closed

test failure #118

wwood opened this issue May 21, 2016 · 4 comments

Comments

@wwood
Copy link

wwood commented May 21, 2016

Hi,

I just came across this test error:

  1) Error:
MIME::Types::Cache::.load#test_0003_outputs an error when there is an invalid version:
RuntimeError: can't modify frozen String
    /tmp/nix-build-ruby-mime-types-3.0.drv-0/gem/test/test_mime_types_cache.rb:40:in `gsub!'
    /tmp/nix-build-ruby-mime-types-3.0.drv-0/gem/test/test_mime_types_cache.rb:40:in `block (3 levels) in <top (required)>'

143 runs, 271 assertions, 0 failures, 1 errors, 0 skips

Any ideas? This is using gem v3.0, but this line of code is still in master too. This is using Ruby 2.3.1.

Thanks.
@halostatue
Copy link
Member

Yeah. I have a fix for this coming shortly.

halostatue added a commit that referenced this issue May 22, 2016
@halostatue
mime-types 3.1
21c4425 
*   3 bug fixes

    *   A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
        strings #118. This has been fixed.

    *   The JSON data has been incorrectly encoded since the release of
        mime-types 3 on the +xrefs+ field, because of the switch to using a Set
        to store cross-reference information. This has been fixed.

    *   A tentative fix for #117 has been applied, removing the only circular
        require dependencies that exist (and for which there was code to
        prevent, but the current fix is simpler). I have no way to verify this
        fix and depending on how things are loaded by `delayed_job`, this fix
        may not be sufficient.

*   1 governance change

    *   Updated to Contributor Covenant 1.4.
@halostatue halostatue mentioned this issue May 22, 2016
Merged
@halostatue
Copy link
Member

This is now fixed on mime-types-3.1-pre which should be released as mime-types 3.1 tomorrow.

@wwood
Copy link
Author

wwood commented May 22, 2016

Great, thanks.

halostatue added a commit that referenced this issue May 22, 2016
@halostatue
mime-types 3.1
6fc325f 
*   3 bug fixes

    *   A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
        strings #118. This has been fixed.

    *   The JSON data has been incorrectly encoded since the release of
        mime-types 3 on the +xrefs+ field, because of the switch to using a Set
        to store cross-reference information. This has been fixed.

    *   A tentative fix for #117 has been applied, removing the only circular
        require dependencies that exist (and for which there was code to
        prevent, but the current fix is simpler). I have no way to verify this
        fix and depending on how things are loaded by `delayed_job`, this fix
        may not be sufficient.

*   1 governance change

    *   Updated to Contributor Covenant 1.4.
halostatue added a commit that referenced this issue May 22, 2016
@halostatue
mime-types 3.1 (#120)
aa499d1 
*   3 bug fixes

    *   A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
        strings #118. This has been fixed.

    *   The JSON data has been incorrectly encoded since the release of
        mime-types 3 on the +xrefs+ field, because of the switch to using a Set
        to store cross-reference information. This has been fixed.

    *   A tentative fix for #117 has been applied, removing the only circular
        require dependencies that exist (and for which there was code to
        prevent, but the current fix is simpler). I have no way to verify this
        fix and depending on how things are loaded by `delayed_job`, this fix
        may not be sufficient.

*   1 governance change

    *   Updated to Contributor Covenant 1.4.
@halostatue
Copy link
Member

mime-types 3.1 has been released with a fix for this issue.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 15, 2016
Update ruby-mime-types to 3.1.
a82ff6d 
== 3.1 / 2016-05-22

* 1 documentation change:

  * Tim Smith (@tas50) updated the build badges to be SVGs to improve
    readability on high-density (retina) screens with pull request
    {#112}[mime-types/ruby-mime-types#112].

* 3 bug fixes

  * A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
    strings, {#118}[mime-types/ruby-mime-types#118].
    This has been fixed.

  * The JSON data has been incorrectly encoded since the release of mime-types
    3 on the +xrefs+ field, because of the switch to using a Set to store
    cross-reference information. This has been fixed.

  * A tentative fix for
    {#117}[mime-types/ruby-mime-types#117] has been
    applied, removing the only circular require dependencies that exist (and
    for which there was code to prevent, but the current fix is simpler).
    I have no way to verify this fix and depending on how things are loaded by
    +delayed_job+, this fix may not be sufficient.

* 1 governance change

  * Updated to {Contributor Covenant 1.4}[Code-of-Conduct_rdoc.html].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@halostatue @wwood