Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: infer_dtype_bydata can not infer DataType.ARRAY #2165

Open
1 task done
zc277584121 opened this issue Jul 3, 2024 · 4 comments
Open
1 task done

[Enhancement]: infer_dtype_bydata can not infer DataType.ARRAY #2165

zc277584121 opened this issue Jul 3, 2024 · 4 comments
Labels
kind/enhancement New feature or request

Comments

@zc277584121
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

img_v3_02cd_b8dc5f62-0f18-47cb-89a3-8014d7ade12g
I have tried some examples, and infer_dtype_bydata can not infer DataType.ARRAY from any type of array-like data. Maybe pymilvus should offer a function to infer a ARRAY datatype, as well as the element type within the array.

Why is this needed?

Because someone want to use this function to infer ARRAY type from metadata in Langchain.
https://github.com/langchain-ai/langchain/pull/23219/files#diff-e5632024b6ba1822184894603c61d3abe15be32464c94feaf805e4af6061730cR419
In the past, we can use infer_dtype_bydata to infer any types such as FLOAT_VECTOR. However, this failed when infering ARRAY data

Anything else?

No response

@zc277584121
Copy link
Author

This issue is similar to #1785

@rgupta2508
Copy link

Added PR to resolve this #2144

Please review

@rgupta2508
Copy link

rgupta2508 commented Jul 3, 2024

For int array also it will return datatype as FLOAT_VECTOR, for float array also same issue

@rgupta2508
Copy link

#1785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants