-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add csv support for bulkinsert #34938
enhance: add csv support for bulkinsert #34938
Conversation
Welcome @OxalisCu! It looks like this is your first PR to milvus-io/milvus 🎉 |
overall looks good to me |
d76c717
to
6a07f2c
Compare
@OxalisCu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
@OxalisCu E2e jenkins job failed, comment |
a39bce4
to
edaf61a
Compare
@OxalisCu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
4fdb586
to
5f37acb
Compare
/lgtm |
@OxalisCu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
06811d7
to
db08848
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34938 +/- ##
==========================================
+ Coverage 72.40% 81.38% +8.97%
==========================================
Files 1234 1236 +2
Lines 146916 147370 +454
==========================================
+ Hits 106374 119932 +13558
+ Misses 35832 22683 -13149
- Partials 4710 4755 +45
|
db08848
to
7ce54a2
Compare
Signed-off-by: OxalisCu <[email protected]>
Signed-off-by: OxalisCu <[email protected]>
Signed-off-by: OxalisCu <[email protected]>
Signed-off-by: OxalisCu <[email protected]>
Signed-off-by: OxalisCu <[email protected]>
7ce54a2
to
11a0677
Compare
Signed-off-by: OxalisCu <[email protected]>
11a0677
to
1e1e57c
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, OxalisCu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Milvus has supported csv format in bulkinsert, this pr synchronizes this support to pymilvus. See this pr in milvus for detail information milvus-io/milvus#34938 --------- Signed-off-by: OxalisCu <[email protected]>
See this issue for details: #34937