Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add csv support for bulkinsert #34938

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

OxalisCu
Copy link
Contributor

See this issue for details: #34937

@sre-ci-robot
Copy link
Contributor

Welcome @OxalisCu! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jul 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 23, 2024
@bigsheeper
Copy link
Contributor

overall looks good to me

Copy link
Contributor

mergify bot commented Jul 29, 2024

@OxalisCu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Jul 29, 2024
Copy link
Contributor

mergify bot commented Jul 29, 2024

@OxalisCu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@OxalisCu OxalisCu force-pushed the bulkinsert-support-csv branch 2 times, most recently from a39bce4 to edaf61a Compare July 29, 2024 05:46
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jul 29, 2024
@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file labels Jul 30, 2024
Copy link
Contributor

mergify bot commented Jul 30, 2024

@OxalisCu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Jul 30, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jul 30, 2024
@tedxu
Copy link
Contributor

tedxu commented Aug 1, 2024

/lgtm

Copy link
Contributor

mergify bot commented Aug 16, 2024

@OxalisCu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Aug 16, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 72.46696% with 125 lines in your changes missing coverage. Please review.

Project coverage is 81.38%. Comparing base (99f8c64) to head (1e1e57c).
Report is 5 commits behind head on master.

Files Patch % Lines
internal/util/importutilv2/csv/row_parser.go 70.70% 51 Missing and 36 partials ⚠️
internal/util/importutilv2/csv/reader.go 71.92% 8 Missing and 8 partials ⚠️
internal/util/testutil/test_util.go 82.92% 7 Missing and 7 partials ⚠️
internal/util/importutilv2/option.go 55.55% 2 Missing and 2 partials ⚠️
internal/util/importutilv2/reader.go 60.00% 1 Missing and 1 partial ⚠️
internal/util/importutilv2/util.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34938      +/-   ##
==========================================
+ Coverage   72.40%   81.38%   +8.97%     
==========================================
  Files        1234     1236       +2     
  Lines      146916   147370     +454     
==========================================
+ Hits       106374   119932   +13558     
+ Misses      35832    22683   -13149     
- Partials     4710     4755      +45     
Files Coverage Δ
internal/util/importutilv2/reader.go 69.56% <60.00%> (-2.66%) ⬇️
internal/util/importutilv2/util.go 53.33% <50.00%> (-0.52%) ⬇️
internal/util/importutilv2/option.go 65.95% <55.55%> (-2.47%) ⬇️
internal/util/testutil/test_util.go 93.25% <82.92%> (-1.88%) ⬇️
internal/util/importutilv2/csv/reader.go 71.92% <71.92%> (ø)
internal/util/importutilv2/csv/row_parser.go 70.70% <70.70%> (ø)

... and 238 files with indirect coverage changes

@tedxu
Copy link
Contributor

tedxu commented Aug 21, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, OxalisCu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ed4eaff into milvus-io:master Aug 21, 2024
14 of 16 checks passed
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this pull request Sep 5, 2024
Milvus has supported csv format in bulkinsert, this pr synchronizes this
support to pymilvus.
See this pr in milvus for detail information
milvus-io/milvus#34938

---------

Signed-off-by: OxalisCu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants