Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Error Should Have an Error Code #176

Open
jmakar-boom opened this issue Jul 25, 2022 · 1 comment
Open

Runtime Error Should Have an Error Code #176

jmakar-boom opened this issue Jul 25, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jmakar-boom
Copy link

jmakar-boom commented Jul 25, 2022

Version affected
0.1.31

Describe the bug
I have a multi-source stream to which nothing is being broadcast. A client attempts to connect to listen for broadcast events. The client receives a runtime error with no useable error code. As this is a predictable error I would expect some kind fo error code for handling in the client. It results in a 400 HTTP status error saying 'stream not being published'.

To Reproduce
Steps to reproduce the behavior:
Run this code snippet with an initialized millicastView instance.

//Start connection to publisher
try {
    await millicastView.connect({
        events: ["active", "inactive", "vad", "layers"]
    })
    
} catch (e) {
    console.log("error", e);
}

Expected behavior
I would expect an error code for handling the client behavior. To be honest, I personally would prefer no error and allow it to sit there and listen for broadcast events anyway. But if it must fail, I would like a handleable error code.

Screenshots
image
image

Environment (please complete the following information):
n/a

Additional context
Multi-source stream, if that matters

@jmakar-boom jmakar-boom added the bug Something isn't working label Jul 25, 2022
@nico-ramos nico-ramos added enhancement New feature or request and removed bug Something isn't working labels Aug 1, 2022
@nico-ramos
Copy link
Contributor

Hi, we're going to work on that in the future, for now you should handle the different errors by it's message.
I can't give you an estimate of when it will be done since it's going to be mainly a server-side fix.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants