Only run oauth tests if a connection succeeds #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the autopkgtest infrastructure for Ubuntu we use a squid proxy and were not receiving an OSError in _oauth_request but instead were receiving a 403 status code. Regardless, checking for the status_code of the session.get() call seems like a good idea in general.
mikf
reviewed
Jul 27, 2020
Comment on lines
+105
to
+108
| if connection.status_code == 200: | ||
| return connection.text | ||
| else: | ||
| raise unittest.SkipTest() |
There was a problem hiding this comment.
Suggested change
| if connection.status_code == 200: | |
| return connection.text | |
| else: | |
| raise unittest.SkipTest() | |
| connection.raise_for_status() | |
| return connection.text |
We should just call raise_for_status() here to avoid code duplication.
It might also be sensible to raise unittest.SkipTest() unconditionally at the beginning of _oauth_request() since the public test server at term.ie is not available anymore and hasn't been for some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the autopkgtest infrastructure for Ubuntu we use a squid proxy and were not receiving an OSError in _oauth_request but instead were receiving a 403 status code. Regardless, checking for the status_code of the session.get() call seems like a good idea in general.