Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twitter] extractor.*.retries is not respected #801

Closed
rEnr3n opened this issue May 30, 2020 · 3 comments
Closed

[Twitter] extractor.*.retries is not respected #801

rEnr3n opened this issue May 30, 2020 · 3 comments

Comments

@rEnr3n
Copy link

rEnr3n commented May 30, 2020

config.txt

{
    "extractor": {
        "retries": -1
    }
}
$ gallery-dl -v --ignore-config -c config.txt https://twitter.com/220cmjessica/status/1266215449588494336                                                                                                         :(
[gallery-dl][debug] Version 1.13.6
[gallery-dl][debug] Python 3.8.3 - Linux-5.6.14-arch1-1-x86_64-with-glibc2.2.5
[gallery-dl][debug] requests 2.23.0 - urllib3 1.25.9
[gallery-dl][debug] Starting DownloadJob for 'https://twitter.com/220cmjessica/status/1266215449588494336'
[twitter][debug] Using TwitterTweetExtractor for 'https://twitter.com/220cmjessica/status/1266215449588494336'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): twitter.com:443
[urllib3.connectionpool][debug] https://twitter.com:443 "GET /i/web/status/1266215449588494336 HTTP/1.1" 200 59693
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): api.twitter.com:443
[urllib3.connectionpool][debug] https://api.twitter.com:443 "POST /1.1/guest/activate.json HTTP/1.1" 200 63
[urllib3.connectionpool][debug] https://api.twitter.com:443 "GET /1.1/videos/tweet/config/1266215449588494336.json HTTP/1.1" 200 1208
[downloader.ytdl][debug] [generic] g2FGHOgeEYMhs_KO: Requesting header
[downloader.ytdl][warning] Could not send HEAD request to https://video.twimg.com/ext_tw_video/1266215394768850948/pu/pl/g2FGHOgeEYMhs_KO.m3u8?tag=10: <urlopen error [Errno -3] Temporary failure in name resolution>
[downloader.ytdl][debug] [generic] g2FGHOgeEYMhs_KO: Downloading webpage
[downloader.ytdl][error] ERROR: Unable to download webpage: <urlopen error [Errno -3] Temporary failure in name resolution> (caused by URLError(gaierror(-3, 'Temporary failure in name resolution')))
[download][error] Failed to download 1266215449588494336_1.mp4

It doesn't seem to use the default retries of 4 either.

@mikf
Copy link
Owner

mikf commented Jun 10, 2020

This is the result of a missing feature in youtube-dl. It has a retries option, but it only applies for file downloads. Network errors before that stage don't get retried by it.

The new Twitter code (#806) won't need youtube-dl for video downloads anymore, so at least there it shouldn't be an issue anymore

@ntqr
Copy link

ntqr commented Jun 12, 2020

@mikf
Wait so does that mean extractor.twitter.videos will work differently?
Will setting it to 'true' now mean that gallery-dl will handle all the video extraction without youtube-dl's help?

@mikf
Copy link
Owner

mikf commented Jun 13, 2020

@anonieee
Exactly. The new version won't use youtube-dl to download videos from Twitter anymore, unless you explicitly tell it to by setting extractor.twitter.videos to "ytdl"

@rEnr3n rEnr3n closed this as completed Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants